jenkins-bot has submitted this change and it was merged.

Change subject: Fix NPE crash in SearchFragment.
......................................................................


Fix NPE crash in SearchFragment.

In the case when the user taps the "Go" button on the soft keyboard, the
closeSearch() method was being called twice! (it's called automatically
from navigateToTitle())

Bug: T146142
Change-Id: Ia835403f4728bef64370f65df41bd430ea597564
---
M app/src/main/java/org/wikipedia/search/SearchFragment.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Niedzielski: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/search/SearchFragment.java 
b/app/src/main/java/org/wikipedia/search/SearchFragment.java
index 383fc59..5da34c1 100644
--- a/app/src/main/java/org/wikipedia/search/SearchFragment.java
+++ b/app/src/main/java/org/wikipedia/search/SearchFragment.java
@@ -106,7 +106,6 @@
             }
             if (firstResult != null) {
                 navigateToTitle(firstResult, false, 0);
-                closeSearch();
             }
             return true;
         }

-- 
To view, visit https://gerrit.wikimedia.org/r/311699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia835403f4728bef64370f65df41bd430ea597564
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to