Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311749
Change subject: Fix IDEA Ultimate warnings in ChangeTags
......................................................................
Fix IDEA Ultimate warnings in ChangeTags
Change-Id: Ie0778e5e32be81bda246d231526630db700b8538
---
M includes/changetags/ChangeTags.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/49/311749/1
diff --git a/includes/changetags/ChangeTags.php
b/includes/changetags/ChangeTags.php
index 3ef9641..6455a3a 100644
--- a/includes/changetags/ChangeTags.php
+++ b/includes/changetags/ChangeTags.php
@@ -571,7 +571,7 @@
// This function is from revision deletion logic and
has nothing to do with
// change tags, but it appears to be the only other
place in core where we
// perform logged actions on log items.
- $logEntry->setTarget( RevDelLogList::suggestTarget( 0,
[ $log_id ] ) );
+ $logEntry->setTarget( RevDelLogList::suggestTarget(
null, [ $log_id ] ) );
}
if ( !$logEntry->getTarget() ) {
@@ -1038,7 +1038,7 @@
// let's not allow error results, as the actual tag deletion
succeeded
if ( !$status->isOK() ) {
wfDebug( 'ChangeTagAfterDelete error condition
downgraded to warning' );
- $status->ok = true;
+ $status->setOK( true );
}
// clear the memcache of defined tags
--
To view, visit https://gerrit.wikimedia.org/r/311749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0778e5e32be81bda246d231526630db700b8538
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
