Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311852

Change subject: Fix regression that embedded video player didn't work
......................................................................

Fix regression that embedded video player didn't work

A small update to the markup didn't match the JS, causing
the player to be hidden in the embedded mode sometimes.
Go back to using an explicit id wrapper, seems to work.

Bug: T146124
Change-Id: Iac3b97c86aedb96b2c0e5b4eed2cb30c606fe23a
---
M TimedMediaIframeOutput.php
M resources/embedPlayerIframe.css
2 files changed, 5 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/52/311852/1

diff --git a/TimedMediaIframeOutput.php b/TimedMediaIframeOutput.php
index 1db1326..e851658 100644
--- a/TimedMediaIframeOutput.php
+++ b/TimedMediaIframeOutput.php
@@ -97,7 +97,9 @@
        ?>
 <body>
                <img src="<?php echo $videoTransform->getUrl(); ?>" 
id="bgimage" ></img>
-               <?php echo $videoTransform->toHtml(); ?>
+               <div id="videoContainer">
+                       <?php echo $videoTransform->toHtml(); ?>
+               </div>
        <?php echo $wgOut->getBottomScripts(); ?>
 </body>
 </html>
diff --git a/resources/embedPlayerIframe.css b/resources/embedPlayerIframe.css
index 3fb3f32..4027208 100644
--- a/resources/embedPlayerIframe.css
+++ b/resources/embedPlayerIframe.css
@@ -18,9 +18,9 @@
        width:100%;
        height:100%;
 }
-.mediaContainer {
+#videoContainer {
        visibility: hidden;
 }
-.mediaContainer .videoHolder {
+#videoContainer .videoHolder {
        position: static;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/311852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac3b97c86aedb96b2c0e5b4eed2cb30c606fe23a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to