jenkins-bot has submitted this change and it was merged.
Change subject: VE: Ensure ext.pygments module gets loaded when a user adds a
syntax highlight node
......................................................................
VE: Ensure ext.pygments module gets loaded when a user adds a syntax highlight
node
Otherwise it won't get styled unless VE was loaded on a read page with one
existing.
Bug: T60388
Change-Id: I32c02eda1e7dca077340c2bf3c15aadad7e3b61a
---
M modules/ve-syntaxhighlight/ve.ce.MWSyntaxHighlightNode.js
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-syntaxhighlight/ve.ce.MWSyntaxHighlightNode.js
b/modules/ve-syntaxhighlight/ve.ce.MWSyntaxHighlightNode.js
index 4176d1e..7331237 100644
--- a/modules/ve-syntaxhighlight/ve.ce.MWSyntaxHighlightNode.js
+++ b/modules/ve-syntaxhighlight/ve.ce.MWSyntaxHighlightNode.js
@@ -30,11 +30,15 @@
/** */
ve.ce.MWSyntaxHighlightNode.prototype.generateContents = function () {
+ var node = this,
+ args = arguments;
if ( !this.getModel().isLanguageSupported() ) {
return $.Deferred().reject().promise();
}
// Parent method
- return ve.ce.MWExtensionNode.prototype.generateContents.apply( this,
arguments );
+ return mw.loader.using( 'ext.pygments' ).then( function () {
+ return ve.ce.MWExtensionNode.prototype.generateContents.apply(
node, args );
+ } );
};
/** */
--
To view, visit https://gerrit.wikimedia.org/r/311839
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32c02eda1e7dca077340c2bf3c15aadad7e3b61a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <a...@wikimedia.org>
Gerrit-Reviewer: Alex Monk <a...@wikimedia.org>
Gerrit-Reviewer: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
