Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311875
Change subject: jsduck: Remove custom @source tag
......................................................................
jsduck: Remove custom @source tag
Only used in external.js to render a simple link. These methods
don't have a regular description and as such the link renders
effectively the same way in the same place without `@source`.
Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
---
M .jscsrc
M jsduck.external.js
M jsduck_custom_tags.rb
3 files changed, 10 insertions(+), 27 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/75/311875/1
diff --git a/.jscsrc b/.jscsrc
index 91dcadb..4bb4c0c 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -6,7 +6,6 @@
"preset": "jsduck5",
"extra": {
"mixin": false,
- "source": true,
"todo": true,
"see": true
}
diff --git a/jsduck.external.js b/jsduck.external.js
index 907869c..14eb9e8 100644
--- a/jsduck.external.js
+++ b/jsduck.external.js
@@ -1,47 +1,48 @@
/**
+ * Source: <https://api.jquery.com/>
* @class jQuery
- * <http://api.jquery.com/>
*/
/**
+ * Source: <https://api.jquery.com/jQuery.ajax/>
* @method ajax
- * @source <http://api.jquery.com/jQuery.ajax/>
+ * @static
* @return {jqXHR}
*/
/**
+ * Source: <https://api.jquery.com/Types/#Event>
* @class jQuery.Event
- * @source <http://api.jquery.com/Types/#Event>
*/
/**
+ * Source: <https://api.jquery.com/Types/#Promise>
* @class jQuery.Promise
- * @source <http://api.jquery.com/Types/#Promise>
*/
/**
+ * Source: <https://api.jquery.com/jQuery.Deferred/>
* @class jQuery.Deferred
* @mixins jQuery.Promise
- * @source <http://api.jquery.com/jQuery.Deferred/>
*/
/**
+ * Source: <https://api.jquery.com/Types/#jqXHR>
* @class jQuery.jqXHR
- * @source <http://api.jquery.com/Types/#jqXHR>
* @alternateClassName jqXHR
*/
/**
+ * Source: <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api>
* @class mw.Api
- * @source <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api>
*/
/**
+ * Source:
<https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Message
* @class mw.Message
- * @source
<https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Message
*/
/**
+ * Source: <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Title>
* @class mw.Title
- * @source <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Title>
*/
diff --git a/jsduck_custom_tags.rb b/jsduck_custom_tags.rb
index 083f45a..6a4da00 100644
--- a/jsduck_custom_tags.rb
+++ b/jsduck_custom_tags.rb
@@ -31,23 +31,6 @@
end
end
-class SourceTag < CommonTag
- def initialize
- @tagname = :source
- @pattern = 'source'
- super
- end
-
- def to_html(context)
- context[@tagname].map do |source|
- <<-EOHTML
- <h3 class='pa'>Source</h3>
- #{source[:doc]}
- EOHTML
- end.join
- end
-end
-
class SeeTag < CommonTag
def initialize
@tagname = :see
--
To view, visit https://gerrit.wikimedia.org/r/311875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
