Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311876

Change subject: jsduck: Remove custom @source tag
......................................................................

jsduck: Remove custom @source tag

Only used in external.js to render a simple link. These methods
don't have a regular description and as such the link renders
effectively the same way in the same place without `@source`.

Also:
* Add missing '@static' to jQuery.ajax (matches MediaWiki core).
* Add 'docs/' to .gitignore to avoid a dirty state after
  running 'npm run doc'.

Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
---
M .gitignore
M jsduck.external.js
M jsduck_custom_tags.rb
3 files changed, 13 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/76/311876/1

diff --git a/.gitignore b/.gitignore
index 35d2258..f53c5df 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,3 +13,4 @@
 vendor/autoload.php
 \#*#
 /composer.lock
+/docs
diff --git a/jsduck.external.js b/jsduck.external.js
index 8c5c469..9684cc1 100644
--- a/jsduck.external.js
+++ b/jsduck.external.js
@@ -1,58 +1,59 @@
 /**
+ * Source: <https://api.jquery.com/>
  * @class jQuery
- * <http://api.jquery.com/>
  */
 
 /**
+ * Source: <https://api.jquery.com/jQuery.ajax/>
  * @method ajax
- * @source <http://api.jquery.com/jQuery.ajax/>
+ * @static
  * @return {jqXHR}
  */
 
 /**
+ * Source: <https://api.jquery.com/Types/#Event>
  * @class jQuery.Event
- * @source <http://api.jquery.com/Types/#Event>
  */
 
 /**
+ * Source: <https://api.jquery.com/Types/#Promise>
  * @class jQuery.Promise
- * @source <http://api.jquery.com/Types/#Promise>
  */
 
 /**
+ * Source: <https://api.jquery.com/jQuery.Deferred/>
  * @class jQuery.Deferred
  * @mixins jQuery.Promise
- * @source <http://api.jquery.com/jQuery.Deferred/>
  */
 
 /**
+ * Source: <https://api.jquery.com/Types/#jqXHR>
  * @class jQuery.jqXHR
- * @source <http://api.jquery.com/Types/#jqXHR>
  * @alternateClassName jqXHR
  */
 
 /**
+ * Source: <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api>
  * @class mw.Api
- * @source <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api>
  */
 
 /**
+ * Source: 
<https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Message
  * @class mw.Message
- * @source 
<https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Message
  */
 
 /**
+ * Source: <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Title>
  * @class mw.Title
- * @source <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Title>
  */
 
 /**
+ * Source: <http://handlebarsjs.com/reference.html>
  * @class Handlebars
- * <http://handlebarsjs.com/reference.html>
  */
 
 /**
+ * Source: <http://handlebarsjs.com/reference.html#base-SafeString>
  * @class Handlebars.SafeString
- * <http://handlebarsjs.com/reference.html#base-SafeString>
  */
 
diff --git a/jsduck_custom_tags.rb b/jsduck_custom_tags.rb
index 96b1ea6..e6b19ed 100644
--- a/jsduck_custom_tags.rb
+++ b/jsduck_custom_tags.rb
@@ -31,23 +31,6 @@
   end
 end
 
-class SourceTag < CommonTag
-  def initialize
-    @tagname = :source
-    @pattern = "source"
-    super
-  end
-
-  def to_html(context)
-    context[@tagname].map do |source|
-      <<-EOHTML
-        <h3 class='pa'>Source</h3>
-        #{source[:doc]}
-      EOHTML
-    end.join
-  end
-end
-
 class UntilTag < CommonTag
   def initialize
     @tagname = :until

-- 
To view, visit https://gerrit.wikimedia.org/r/311876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to