Cdentinger has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311910

Change subject: Return true from job&execute()
......................................................................

Return true from job&execute()

The listener script expects it

Change-Id: I2d4630370b752b6d9c7b375dd5ddad543fc4275b
---
M PaymentProviders/PayPal/Job.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/10/311910/1

diff --git a/PaymentProviders/PayPal/Job.php b/PaymentProviders/PayPal/Job.php
index c1b7711..00848e0 100644
--- a/PaymentProviders/PayPal/Job.php
+++ b/PaymentProviders/PayPal/Job.php
@@ -68,5 +68,8 @@
                $this->config->object( 'data-store/' . $msg_type )
                        ->push( $new_msg );
 
+               // TODO It would be nice if push() returned something useful so 
we
+               // could return something here too
+               return true;
        }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/311910
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d4630370b752b6d9c7b375dd5ddad543fc4275b
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Cdentinger <cdentin...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to