jenkins-bot has submitted this change and it was merged.
Change subject: Make PayPal tests get queues directly from config
......................................................................
Make PayPal tests get queues directly from config
Change-Id: I2028a629b7c9434eefeffff31dfe9e54bd557470
---
M PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
b/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
index 740acdf..251780e 100644
--- a/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
+++ b/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
@@ -44,8 +44,7 @@
$this->capture( self::$verified_msg );
- // TODO why get it from BaseQueueConsumer instead of config?
- $jobQueue = BaseQueueConsumer::getQueue( 'jobs-paypal' );
+ $jobQueue = $this->config->object( 'data-store/jobs-paypal' );
$jobMessage = $jobQueue->pop();
$this->assertEquals( $jobMessage['php-message-class'],
@@ -59,8 +58,7 @@
$this->capture( self::$verified_msg );
- // TODO DRY?
- $jobQueue = BaseQueueConsumer::getQueue( 'jobs-paypal' );
+ $jobQueue = $this->config->object( 'data-store/jobs-paypal' );
$jobMessage = $jobQueue->pop();
$job = KeyedOpaqueStorableObject::fromJsonProxy(
--
To view, visit https://gerrit.wikimedia.org/r/311893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2028a629b7c9434eefeffff31dfe9e54bd557470
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
