Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311937
Change subject: Add sanity check to LoadBalancer::setDomainPrefix()
......................................................................
Add sanity check to LoadBalancer::setDomainPrefix()
Change-Id: Ie78fefa1acb401fe4e8bdc96b75053692aa0a925
---
M includes/libs/rdbms/loadbalancer/LoadBalancer.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/37/311937/1
diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
index 9c07043..25eb3b3 100644
--- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@ -1473,6 +1473,11 @@
}
public function setDomainPrefix( $prefix ) {
+ if ( $this->mConns['foreignUsed'] ) {
+ // Do not switch connections to explicit foreign
domains unless marked as free
+ throw new DBUnexpectedError( null, "Foriegn domain
connections are still in use." );
+ }
+
$this->localDomain = new DatabaseDomain(
$this->localDomain->getDatabase(),
null,
--
To view, visit https://gerrit.wikimedia.org/r/311937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie78fefa1acb401fe4e8bdc96b75053692aa0a925
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
