Prtksxna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311995

Change subject: ButtonElement: Remove role="button" as it is the default value
......................................................................

ButtonElement: Remove role="button" as it is the default value

Bug: T145975
Change-Id: I5079cb056d9c1987db359a1dcd16e67c306e1f16
---
M php/mixins/ButtonElement.php
M src/mixins/ButtonElement.js
2 files changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/95/311995/1

diff --git a/php/mixins/ButtonElement.php b/php/mixins/ButtonElement.php
index 1a667b9..7b941d7 100644
--- a/php/mixins/ButtonElement.php
+++ b/php/mixins/ButtonElement.php
@@ -40,9 +40,6 @@
                $this->addClasses( [ 'oo-ui-buttonElement' ] );
                $this->button->addClasses( [ 'oo-ui-buttonElement-button' ] );
                $this->toggleFramed( isset( $config['framed'] ) ? 
$config['framed'] : true );
-               $this->button->setAttributes( [
-                       'role' => 'button',
-               ] );
 
                $this->registerConfigCallback( function( &$config ) {
                        if ( $this->framed !== true ) {
diff --git a/src/mixins/ButtonElement.js b/src/mixins/ButtonElement.js
index 0aab549..076af83 100644
--- a/src/mixins/ButtonElement.js
+++ b/src/mixins/ButtonElement.js
@@ -89,7 +89,6 @@
 
        this.$button = $button
                .addClass( 'oo-ui-buttonElement-button' )
-               .attr( { role: 'button' } )
                .on( {
                        mousedown: this.onMouseDownHandler,
                        keydown: this.onKeyDownHandler,

-- 
To view, visit https://gerrit.wikimedia.org/r/311995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5079cb056d9c1987db359a1dcd16e67c306e1f16
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to