Dbrant has uploaded a new change for review. https://gerrit.wikimedia.org/r/312002
Change subject: Fix crash introduced in previous Hygiene patch. ...................................................................... Fix crash introduced in previous Hygiene patch. After this patch: https://gerrit.wikimedia.org/r/311868 ...the app started crashing when clicking on a News card (bringing up the NewsActivity) with "don't keep activities" enabled (API 23). This seems to be caused by setting the feed callback to null in onDestroyView. It may point to a deeper issue in the lifecycle of our FeedView or ItemTouchHelper, but for now let's revert the change that causes the crash. Change-Id: I705c5bb0ec5a2172c3969ae6f7084f04c9d89cba --- M app/src/main/java/org/wikipedia/feed/FeedFragment.java 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/02/312002/1 diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java b/app/src/main/java/org/wikipedia/feed/FeedFragment.java index 472e094..d7905f3 100644 --- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java +++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java @@ -134,7 +134,6 @@ coordinator.setFeedUpdateListener(null); swipeRefreshLayout.setOnRefreshListener(null); feedView.removeOnScrollListener(feedScrollListener); - feedView.callback((FeedViewCallback) null); unbinder.unbind(); unbinder = null; super.onDestroyView(); -- To view, visit https://gerrit.wikimedia.org/r/312002 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I705c5bb0ec5a2172c3969ae6f7084f04c9d89cba Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
