jenkins-bot has submitted this change and it was merged.

Change subject: Replace core's mw-help-field-hint with wb-help-field-hint
......................................................................


Replace core's mw-help-field-hint with wb-help-field-hint

This is a direct 1:1 copy. I did not touched it on purpose. I will
clean it up in a following patch.

Bug: T144977
Change-Id: I3daec75c832dc509d4ae52fb11af18b8250d775b
---
M tests/browser/features/support/modules/alias_module.rb
M tests/browser/features/support/modules/sitelink_module.rb
M tests/browser/features/support/modules/statement_module.rb
M view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
A 
view/resources/jquery/wikibase/toolbar/themes/default/images/help-question-hover.gif
A view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.gif
M 
view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
M 
view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
M view/resources/templates.php
9 files changed, 25 insertions(+), 6 deletions(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/browser/features/support/modules/alias_module.rb 
b/tests/browser/features/support/modules/alias_module.rb
index 5821bbd..4642082 100644
--- a/tests/browser/features/support/modules/alias_module.rb
+++ b/tests/browser/features/support/modules/alias_module.rb
@@ -16,7 +16,7 @@
   text_field(:aliases_input_empty, xpath: "//div[contains(@class, 
'wikibase-aliasesview')]//li[contains(@class, 'tagadata-choice-empty')]//input")
   text_field(:aliases_input_modified, xpath: "//div[contains(@class, 
'wikibase-aliasesview')]//li[contains(@class, 
'tagadata-choice-modified')]//input")
   text_field(:aliases_input_equal, xpath: "//div[contains(@class, 
'wikibase-aliasesview')]//li[contains(@class, 'tagadata-choice-equal')]//input")
-  span(:aliases_help_field, css: 'div.wikibase-aliasesview 
span.mw-help-field-hint')
+  span(:aliases_help_field, css: 'div.wikibase-aliasesview 
span.wb-help-field-hint')
 
   # aliases methods
   def aliases_array
diff --git a/tests/browser/features/support/modules/sitelink_module.rb 
b/tests/browser/features/support/modules/sitelink_module.rb
index 5e10245..6d0a01d 100644
--- a/tests/browser/features/support/modules/sitelink_module.rb
+++ b/tests/browser/features/support/modules/sitelink_module.rb
@@ -33,7 +33,7 @@
   a(:edit_sitelink_link_en, css: "div[data-wb-sitelinks-group='wikipedia'] 
table tr.wikibase-sitelinkview-enwiki 
span.wikibase-toolbar-button-edit:not(.wikibase-toolbarbutton-disabled) > a")
   a(:edit_sitelink_link_en_disabled, css: 
"div[data-wb-sitelinks-group='wikipedia'] table tr.wikibase-sitelinkview-enwiki 
span.wikibase-toolbar-button-edit.wikibase-toolbarbutton-disabled > a")
   h1(:article_title, xpath: "//h1[contains(@class, 'firstHeading')]")
-  span(:sitelink_help_field, css: "div[data-wb-sitelinks-group='wikipedia'] 
.wikibase-toolbar-container span.mw-help-field-hint")
+  span(:sitelink_help_field, css: "div[data-wb-sitelinks-group='wikipedia'] 
.wikibase-toolbar-container span.wb-help-field-hint")
 
   indexed_property(:sitelinks_form, [
     [:text_field, :site_id_input_field, { css: 
"div[data-wb-sitelinks-group='wikipedia'] ul li:nth-child(%s) 
span.wikibase-sitelinkview-siteid input" }],
diff --git a/tests/browser/features/support/modules/statement_module.rb 
b/tests/browser/features/support/modules/statement_module.rb
index b56a10e..aba3011 100644
--- a/tests/browser/features/support/modules/statement_module.rb
+++ b/tests/browser/features/support/modules/statement_module.rb
@@ -23,7 +23,7 @@
   a(:save_statement_disabled, css: '.wikibase-statementlistview 
div.listview-item 
span.wikibase-toolbar-button-save.wikibase-toolbarbutton-disabled > a')
   a(:cancel_statement, css: '.wikibase-statementlistview div.listview-item 
span.wikibase-toolbar-button-cancel:not(.wikibase-toolbarbutton-disabled) > a')
   a(:cancel_statement_disabled, css: '.wikibase-statementlistview 
div.listview-item 
span.wikibase-toolbar-button-cancel.wikibase-toolbarbutton-disabled > a')
-  span(:statement_help_field, css: 'div.wikibase-statementlistview 
span.mw-help-field-hint')
+  span(:statement_help_field, css: 'div.wikibase-statementlistview 
span.wb-help-field-hint')
   div(:claim_edit_mode, css: '.wb-claim-section div.wb-edit')
   textarea(:claim_value_input_field, css: 'div.wikibase-statementview-mainsnak 
.valueview-input')
 
diff --git 
a/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js 
b/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
index d455a87..b92e100 100644
--- a/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
+++ b/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
@@ -308,7 +308,7 @@
                }
 
                this._$tooltipAnchor = $( '<span/>', {
-                       'class': 'mw-help-field-hint',
+                       'class': 'wb-help-field-hint',
                        html: '&nbsp;' // TODO find nicer way to hack Webkit 
browsers to display tooltip image (see also css)
                } ).toolbaritem();
 
diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question-hover.gif
 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question-hover.gif
new file mode 100644
index 0000000..515138d
--- /dev/null
+++ 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question-hover.gif
Binary files differ
diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.gif
 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.gif
new file mode 100644
index 0000000..b4fc9c5
--- /dev/null
+++ 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.gif
Binary files differ
diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
index cc96b13..cab1ea7 100644
--- 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
+++ 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
@@ -5,3 +5,22 @@
 .wikibase-edittoolbar-container > .wikibase-toolbar {
        padding-left: 0;
 }
+
+/* TODO: For now this is a 1:1 copy from core's 
resources/src/mediawiki.legacy/shared.css. */
+.wb-help-field-hint {
+       display: none;
+       margin-left: 2px;
+       margin-bottom: -8px;
+       padding: 0 0 0 15px;
+       background-image: url( images/help-question.gif );
+       background-position: left center;
+       background-repeat: no-repeat;
+       cursor: pointer;
+       font-size: .8em;
+       text-decoration: underline;
+       color: #0645ad;
+}
+
+.wb-help-field-hint:hover {
+       background-image: url( images/help-question-hover.gif );
+}
diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
index 623a0e3..debfd30 100755
--- 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
+++ 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
@@ -7,7 +7,7 @@
        color: grey;
 }
 
-.wikibase-toolbar-item .mw-help-field-hint {
+.wikibase-toolbar-item .wb-help-field-hint {
        display: inline-block;
        margin-left: 3px;
        padding: 0;
diff --git a/view/resources/templates.php b/view/resources/templates.php
index 138e08a..2b1fd34 100644
--- a/view/resources/templates.php
+++ b/view/resources/templates.php
@@ -330,7 +330,7 @@
 <<<HTML
 <div class="wikibase-pageImage">
        <div class="help">
-               <span class="mw-help-field-hint wikibase-toolbar-item 
wikibase-wbtooltip" title="$1">&nbsp;</span>
+               <span class="wb-help-field-hint wikibase-toolbar-item 
wikibase-wbtooltip" title="$1">&nbsp;</span>
        </div>
 </div>
 HTML;

-- 
To view, visit https://gerrit.wikimedia.org/r/312001
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3daec75c832dc509d4ae52fb11af18b8250d775b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo M├Ąttig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to