jenkins-bot has submitted this change and it was merged.

Change subject: more field tweaks
......................................................................


more field tweaks

Not sure I understand what was going on in here, though...

Change-Id: Ia898e86aa1af7b52afc85675e535330b7af9ac41
---
M SmashPig.yaml
1 file changed, 10 insertions(+), 9 deletions(-)

Approvals:
  Cdentinger: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SmashPig.yaml b/SmashPig.yaml
index a387e9b..e945b59 100644
--- a/SmashPig.yaml
+++ b/SmashPig.yaml
@@ -375,27 +375,28 @@
 
     var_map:
         payment_date: date # needs strtotime(payment_date)
+        # FIXME Recurring messages use non-normalized field names, for example:
         txn_type: txn_type
-        payment_status: payment_status
         parent_txn_id: gateway_parent_id
         txn_id: gateway_txn_id
-        # FIXME: This is only true for refund messages.  How to represent?
+        # FIXME This is only true for refund messages.  Where to represent?
         #txn_id: gateway_refund_id
         mc_currency: currency
+        # FIXME rename refund_type
         reason_code: type
-        test_ipn:  # signals test mode
+        #test_ipn:  # signals test mode
         custom: contribution_tracking_id
         payer_email: email
         first_name: first_name
         last_name: last_name
         # FIXME this used to get split up
-        address_street: supplemental_address_1
-        address_city: city_2
-        address_state: state_province_2
-        address_country_code: country_2
-        address_zip: postal_code_2
+        address_street: street_address
+        address_city: city
+        address_state: state_province
+        address_country_code: country
+        address_zip: postal_code
         # FIXME this too
-        address_name: supplemental_address_2
+        address_name: supplemental_address_1
         gateway: gateway
         mc_gross: gross
         mc_fee: fee

-- 
To view, visit https://gerrit.wikimedia.org/r/311925
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia898e86aa1af7b52afc85675e535330b7af9ac41
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to