Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312038
Change subject: Editor: do not use grid for caret spacing
......................................................................
Editor: do not use grid for caret spacing
We were using "eleven columns" to give one column space for the carrot.
Switched to fixed 40px padding, except for the title line where it is
undone.
Bug: T146134
Change-Id: I7948dfa954b3d0c7088946040eb0ae5ead54247c
---
M resources/css/ext.translate.editor.css
M resources/js/ext.translate.editor.js
2 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/38/312038/1
diff --git a/resources/css/ext.translate.editor.css
b/resources/css/ext.translate.editor.css
index d46f344..c301366 100644
--- a/resources/css/ext.translate.editor.css
+++ b/resources/css/ext.translate.editor.css
@@ -42,6 +42,13 @@
border-right: 1px solid #AAA;
-webkit-transition: width 0.5s;
transition: width 0.5s;
+ /* Padding to have space for the arrow indicating split section */
+ padding-right: 40px;
+}
+
+.grid .tux-message-editor .tux-editor-titletools {
+ /* Ignore the padding added for the arrow */
+ margin-right: -40px;
}
.tux-message-editor textarea {
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index fc57a3d..148768d 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -489,7 +489,7 @@
.append( $closeIcon, $infoToggleIcon );
$editorColumn.append( $( '<div>' )
- .addClass( 'row' )
+ .addClass( 'row tux-editor-titletools' )
.append( $messageKeyLabel, $layoutActions )
);
@@ -497,7 +497,7 @@
originalTranslation = this.message.translation;
sourceString = this.message.definition;
$sourceString = $( '<span>' )
- .addClass( 'eleven column sourcemessage' )
+ .addClass( 'twelve columns sourcemessage' )
.attr( {
lang: $messageList.data(
'sourcelangcode' ),
dir: $messageList.data( 'sourcelangdir'
)
@@ -665,7 +665,7 @@
$editAreaBlock = $( '<div>' )
.addClass( 'row tux-editor-editarea-block' )
.append( $( '<div>' )
- .addClass( 'editarea eleven columns' )
+ .addClass( 'editarea twelve columns' )
.append( $warningsBlock, $textarea )
);
@@ -733,7 +733,7 @@
}
$editingButtonBlock = $( '<div>' )
- .addClass( 'ten columns
tux-editor-insert-buttons' )
+ .addClass( 'twelve columns
tux-editor-insert-buttons' )
.append(
$pasteOriginalButton,
$discardChangesButton
@@ -743,7 +743,7 @@
.addClass( 'row
tux-editor-editsummary-block' )
.append(
$( '<div>' )
- .addClass( 'eleven
columns' )
+ .addClass( 'twelve
columns' )
.append( $editSummary )
);
--
To view, visit https://gerrit.wikimedia.org/r/312038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7948dfa954b3d0c7088946040eb0ae5ead54247c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
