jenkins-bot has submitted this change and it was merged.

Change subject: Replace wb-help-field-hint icon with SVG
......................................................................


Replace wb-help-field-hint icon with SVG

I'm strictly sticking to the old design. I believe we should redesign
this, but not in this patch.

Bug: T144977
Change-Id: I810688da763a9130bc5d0a8542ac5426bf6ef53d
---
D 
view/resources/jquery/wikibase/toolbar/themes/default/images/help-question-hover.gif
D view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.gif
A view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.png
A view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.svg
M 
view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
5 files changed, 16 insertions(+), 5 deletions(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question-hover.gif
 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question-hover.gif
deleted file mode 100644
index 515138d..0000000
--- 
a/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question-hover.gif
+++ /dev/null
Binary files differ
diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.gif
 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.gif
deleted file mode 100644
index b4fc9c5..0000000
--- 
a/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.gif
+++ /dev/null
Binary files differ
diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.png
 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.png
new file mode 100644
index 0000000..c9933da
--- /dev/null
+++ 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.png
Binary files differ
diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.svg
 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.svg
new file mode 100644
index 0000000..1e2f039
--- /dev/null
+++ 
b/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.svg
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<svg xmlns="http://www.w3.org/2000/svg"; width="11" height="111">
+<rect style="fill:#ffffff;stroke:#4d4d4d" width="10" height="10" x="0.5" 
y="0.5" ry="0.5" />
+<path style="fill:#000000" d="M 5.4473626,5.6073306 C 5.563295,5.5195074 
5.7589374,5.3846312 6.0342904,5.2027014 6.3168806,5.0145056 6.537884,4.8608094 
6.6973015,4.7416122 6.8639547,4.6224234 7.0197441,4.4655905 7.16467,4.2711131 
7.3095847,4.0703716 7.3820449,3.8696255 7.3820507,3.6688742 7.3820449,3.380307 
7.2624856,3.151331 7.0233725,2.9819456 6.7914946,2.8062986 6.494408,2.7184723 
6.1321117,2.7184661 5.2625854,2.7184723 4.635805,3.1764243 4.2517689,4.0923235 
L 3.2952939,3.9888136 C 3.7952672,2.6902423 4.7952173,2.0409543 
6.2951472,2.0409474 6.9182998,2.0409543 7.4218979,2.1664205 7.8059429,2.4173467 
8.1899755,2.6620124 8.381995,3.0101814 8.3820017,3.4618547 8.381995,3.7567059 
8.2986658,4.0358684 8.1320139,4.299343 7.9653491,4.5565536 7.7769527,4.763573 
7.5668242,4.9204019 7.3639298,5.0709654 7.1139423,5.2528915 6.8168608,5.4661808 
6.5197691,5.679477 6.2987656,5.8551298 6.1538498,5.9931398 5.8495126,6.2879886 
5.6248861,6.7020273 5.4799697,7.2352575 l -0.967344,0 0.097821,-0.3858093 C 
4.6756581,6.5985176 4.7915944,6.3601317 4.958256,6.1342895 5.1321571,5.9021797 
5.2951924,5.7265269 5.4473626,5.6073306 M 4.0561263,8.8914143 
4.284376,7.9504161 l 1.0869034,0 -0.2282498,0.9409982 -1.0869033,0" />
+<rect ry="0.5" y="100.5" x="0.5" height="10" width="10" 
style="fill:#ffffff;stroke:#0645ad" />
+<path style="fill:#0645ad" d="m 5.4473629,105.60733 c 0.1159327,-0.0878 
0.3115752,-0.2227 0.5869285,-0.40463 0.2825895,-0.18819 0.5035936,-0.34189 
0.6630111,-0.46109 0.1666525,-0.11919 0.3224417,-0.27602 0.4673685,-0.4705 
0.144914,-0.20074 0.2173747,-0.40148 0.2173801,-0.60224 -5.4e-6,-0.28856 
-0.1195653,-0.51754 -0.3586775,-0.68692 -0.2318782,-0.17565 -0.5289648,-0.26348 
-0.891261,-0.26348 -0.8695266,0 -1.4963073,0.45795 -1.8803431,1.37385 l 
-0.9564747,-0.10351 c 0.4999728,-1.29857 1.4999226,-1.94786 2.9998529,-1.94786 
0.6231523,0 1.1267513,0.12547 1.5107957,0.3764 0.3840327,0.24466 
0.5760522,0.59283 0.5760586,1.0445 -6.4e-6,0.29486 -0.083335,0.57402 
-0.2499874,0.83749 -0.1666644,0.25721 -0.355061,0.46423 -0.5651898,0.62106 
-0.2028948,0.15057 -0.4528823,0.33249 -0.7499635,0.54578 -0.297092,0.2133 
-0.518095,0.38895 -0.6630111,0.52696 -0.3043368,0.29485 -0.5289637,0.70889 
-0.6738798,1.24212 l -0.9673446,0 0.097822,-0.38581 c 0.065215,-0.25093 
0.1811464,-0.48932 0.3478087,-0.71516 0.1739006,-0.23211 0.3369367,-0.40776 
0.4891061,-0.52696 m -1.3912359,3.28408 0.2282499,-0.94099 1.0869035,0 
-0.2282499,0.94099 -1.0869035,0" />
+</svg>
diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
index 8236f90..31e5daa 100644
--- 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
+++ 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
@@ -9,17 +9,21 @@
 
 /* This is partially copied from core's 
resources/src/mediawiki.legacy/shared.css. */
 .wb-help-field-hint {
-       /* TODO: Replace with a single SVG. */
-       background-image: url( images/help-question.gif );
-       background-position: left center;
+       /* SVG support using a transparent gradient to guarantee cross-browser
+        * compatibility (browsers able to understand gradient syntax support 
also SVG).
+        * 
http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique */
+       background-image: url(images/help-question.png);
+       background-image: linear-gradient(transparent, transparent), 
url(images/help-question.svg);
+       background-position: 0 0;
        background-repeat: no-repeat;
        cursor: pointer;
        display: inline-block;
+       height: 11px;
        margin-left: 3px;
+       vertical-align: middle;
        width: 11px;
 }
 
 .wb-help-field-hint:hover {
-       /* TODO: Replace with a single SVG. */
-       background-image: url( images/help-question-hover.gif );
+       background-position: 0 -100px;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/312009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I810688da763a9130bc5d0a8542ac5426bf6ef53d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo M├Ąttig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to