jenkins-bot has submitted this change and it was merged.

Change subject: Simplify copy-pasted wb-help-field-hint CSS
......................................................................


Simplify copy-pasted wb-help-field-hint CSS

Bug: T144977
Change-Id: I64aa7d8a641e37a0f890a55f0f3f3ec38dcf8851
---
M 
view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
M 
view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
2 files changed, 7 insertions(+), 16 deletions(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  Thiemo Mättig (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
index cab1ea7..8236f90 100644
--- 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
+++ 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
@@ -1,26 +1,25 @@
 /**
  * @license GNU GPL v2+
  * @author H. Snater < mediaw...@snater.com >
+ * @author Thiemo Mättig
  */
 .wikibase-edittoolbar-container > .wikibase-toolbar {
        padding-left: 0;
 }
 
-/* TODO: For now this is a 1:1 copy from core's 
resources/src/mediawiki.legacy/shared.css. */
+/* This is partially copied from core's 
resources/src/mediawiki.legacy/shared.css. */
 .wb-help-field-hint {
-       display: none;
-       margin-left: 2px;
-       margin-bottom: -8px;
-       padding: 0 0 0 15px;
+       /* TODO: Replace with a single SVG. */
        background-image: url( images/help-question.gif );
        background-position: left center;
        background-repeat: no-repeat;
        cursor: pointer;
-       font-size: .8em;
-       text-decoration: underline;
-       color: #0645ad;
+       display: inline-block;
+       margin-left: 3px;
+       width: 11px;
 }
 
 .wb-help-field-hint:hover {
+       /* TODO: Replace with a single SVG. */
        background-image: url( images/help-question-hover.gif );
 }
diff --git 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
index debfd30..fcfafec 100755
--- 
a/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
+++ 
b/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
@@ -7,14 +7,6 @@
        color: grey;
 }
 
-.wikibase-toolbar-item .wb-help-field-hint {
-       display: inline-block;
-       margin-left: 3px;
-       padding: 0;
-       text-decoration: none;
-       min-width: 11px;
-}
-
 .wikibase-toolbar-item .mw-collapsible-toggle {
        background-position: right;
        background-repeat: no-repeat;

-- 
To view, visit https://gerrit.wikimedia.org/r/312003
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64aa7d8a641e37a0f890a55f0f3f3ec38dcf8851
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to