Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/312075

Change subject: Fix paren nesting bug
......................................................................

Fix paren nesting bug

Just use !empty instead of counting and comparing to zero.

Change-Id: Ifb2482739000f5002af35d2306ecfb876a153ef4
---
M special/SpecialCentralNotice.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/75/312075/1

diff --git a/special/SpecialCentralNotice.php b/special/SpecialCentralNotice.php
index a2da1d9..6e9221c 100644
--- a/special/SpecialCentralNotice.php
+++ b/special/SpecialCentralNotice.php
@@ -958,7 +958,7 @@
                        $htmlOut .= Xml::closeElement( 'table' );
 
                        // Create controls for campaign-associated mixins (if 
there are any)
-                       if ( count( $wgCentralNoticeCampaignMixins > 0 ) ) {
+                       if ( !empty( $wgCentralNoticeCampaignMixins ) ) {
 
                                $mixinsThisNotice = 
Campaign::getCampaignMixins( $notice );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/312075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb2482739000f5002af35d2306ecfb876a153ef4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to