jenkins-bot has submitted this change and it was merged.

Change subject: Only show NWE beta feature if enabled in config
......................................................................


Only show NWE beta feature if enabled in config

Change-Id: Iaa2e3620ab15ece136fe425e61b72f33c8d2f4b4
---
M VisualEditor.hooks.php
1 file changed, 19 insertions(+), 17 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index f9eb001..0d6dc14 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -588,23 +588,25 @@
                        ]
                ];
 
-               $preferences['visualeditor-newwikitext'] = [
-                       'version' => '1.0',
-                       'label-message' => 
'visualeditor-preference-newwikitexteditor-label',
-                       'desc-message' => 
'visualeditor-preference-newwikitexteditor-description',
-                       'screenshot' => [
-                               'ltr' => 
"$iconpath/betafeatures-icon-WikitextEditor-ltr.svg",
-                               'rtl' => 
"$iconpath/betafeatures-icon-WikitextEditor-rtl.svg",
-                       ],
-                       'info-message' => 
'visualeditor-preference-newwikitexteditor-info-link',
-                       'discussion-message' => 
'visualeditor-preference-newwikitexteditor-discussion-link',
-                       'requirements' => [
-                               'javascript' => true,
-                               'blacklist' => $veConfig->get( 
'VisualEditorBrowserBlacklist' ),
-                               'skins' => $veConfig->get( 
'VisualEditorSupportedSkins' ),
-                       ],
-                       'exempt-from-auto-enrollment' => true
-               ];
+               if ( $veConfig->get( 'VisualEditorEnableWikitext' ) ) {
+                       $preferences['visualeditor-newwikitext'] = [
+                               'version' => '1.0',
+                               'label-message' => 
'visualeditor-preference-newwikitexteditor-label',
+                               'desc-message' => 
'visualeditor-preference-newwikitexteditor-description',
+                               'screenshot' => [
+                                       'ltr' => 
"$iconpath/betafeatures-icon-WikitextEditor-ltr.svg",
+                                       'rtl' => 
"$iconpath/betafeatures-icon-WikitextEditor-rtl.svg",
+                               ],
+                               'info-message' => 
'visualeditor-preference-newwikitexteditor-info-link',
+                               'discussion-message' => 
'visualeditor-preference-newwikitexteditor-discussion-link',
+                               'requirements' => [
+                                       'javascript' => true,
+                                       'blacklist' => $veConfig->get( 
'VisualEditorBrowserBlacklist' ),
+                                       'skins' => $veConfig->get( 
'VisualEditorSupportedSkins' ),
+                               ],
+                               'exempt-from-auto-enrollment' => true
+                       ];
+               }
 
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/312100
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa2e3620ab15ece136fe425e61b72f33c8d2f4b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Alex Monk <a...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to