jenkins-bot has submitted this change and it was merged.

Change subject: Drop unused "WikibaseChange" hook
......................................................................


Drop unused "WikibaseChange" hook

There is a "WikibaseChangeNotification" hook identical to this one,
but running on all 4 "notifyOnPage…" methods, not only 2.

I did a GitHub search for "WikibaseChange" and could not find a user
of this hook.

Bug: T103665
Change-Id: Idec9581672d530c33e3dd9333865a892164b263e
---
M repo/includes/Notifications/ChangeNotifier.php
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  Daniel Kinzler: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/includes/Notifications/ChangeNotifier.php 
b/repo/includes/Notifications/ChangeNotifier.php
index 50ec107..65a1d0b 100644
--- a/repo/includes/Notifications/ChangeNotifier.php
+++ b/repo/includes/Notifications/ChangeNotifier.php
@@ -2,7 +2,6 @@
 
 namespace Wikibase\Repo\Notifications;
 
-use Hooks;
 use InvalidArgumentException;
 use Revision;
 use User;
@@ -64,13 +63,11 @@
                }
 
                $change = $this->changeFactory->newFromUpdate( 
EntityChange::REMOVE, $content->getEntity() );
-
                $change->setTimestamp( $timestamp );
                $change->setMetadataFromUser( $user );
 
                $this->transmitChange( $change );
 
-               Hooks::run( 'WikibaseChange', array( $change ) );
                return $change;
        }
 
@@ -102,7 +99,6 @@
 
                $this->transmitChange( $change );
 
-               Hooks::run( 'WikibaseChange', array( $change ) );
                return $change;
        }
 
@@ -127,7 +123,6 @@
                }
 
                $change = $this->changeFactory->newFromUpdate( 
EntityChange::ADD, null, $content->getEntity() );
-
                $change->setRevisionInfo( $revision );
 
                // FIXME: RepoHooks::onRecentChangeSave currently adds to the 
change later!

-- 
To view, visit https://gerrit.wikimedia.org/r/311928
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idec9581672d530c33e3dd9333865a892164b263e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to