Awight has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/312160

Change subject: Correct unicode literals
......................................................................

Correct unicode literals

Bug: T144952
Change-Id: Idf25a9ff66d706aacab684876a3d585262402168
---
M includes/BannerRenderer.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/60/312160/1

diff --git a/includes/BannerRenderer.php b/includes/BannerRenderer.php
index 0919aae..7593a86 100644
--- a/includes/BannerRenderer.php
+++ b/includes/BannerRenderer.php
@@ -133,8 +133,9 @@
 
                $bannerKey = $this->banner->getDbKey();
                $bannerHtml = $this->context->msg( $bannerKey )->inLanguage( 
$parentLang )->text();
+               // FIXME: Find a way to use Language::getMessageFor, including 
fallback languages.
                if ( $bannerHtml === "<{$bannerKey}>"
-                       || $bannerHtml === "\u29fc{$bannerKey}\u29fd"
+                       || $bannerHtml === '⧼' . htmlspecialchars( $bannerKey ) 
. '⧽'
                ) {
                        // Translation subsystem failure
                        throw new RuntimeException(

-- 
To view, visit https://gerrit.wikimedia.org/r/312160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf25a9ff66d706aacab684876a3d585262402168
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to