Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312170
Change subject: Strip element IDs from HTML generated when wikitext is pasted ...................................................................... Strip element IDs from HTML generated when wikitext is pasted Bug: T146054 Change-Id: I0013673a9e41ea191ea64f3208a06288efb2ecd3 --- M modules/ve-mw/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.js 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/70/312170/1 diff --git a/modules/ve-mw/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.js b/modules/ve-mw/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.js index 1138852..526b6d3 100644 --- a/modules/ve-mw/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.js +++ b/modules/ve-mw/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.js @@ -96,7 +96,7 @@ // Don't immediately chain, as this.parsoidRequest must be abortable this.parsoidRequest.then( function ( response ) { - var htmlDoc, doc, surface; + var htmlDoc, doc, surface, deleteAttrElements, len; if ( ve.getProp( response, 'visualeditor', 'result' ) !== 'success' ) { return failure(); @@ -104,6 +104,11 @@ htmlDoc = ve.createDocumentFromHtml( response.visualeditor.content ); + deleteAttrElements = htmlDoc.querySelectorAll( '[id]' ); + for ( i = 0, len = deleteAttrElements.length; i < len; i++ ) { + deleteAttrElements[i].removeAttribute( 'id' ); + } + // Pass an empty object for the second argument (importRules) so that clipboard mode is used // TODO: Fix that API doc = handler.surface.getModel().getDocument().newFromHtml( htmlDoc, {} ); -- To view, visit https://gerrit.wikimedia.org/r/312170 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0013673a9e41ea191ea64f3208a06288efb2ecd3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Alex Monk <a...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits