WikidataBuilder has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/312218

Change subject: New Wikidata Build - 2016-09-22T10:00:01+0000
......................................................................

New Wikidata Build - 2016-09-22T10:00:01+0000

Change-Id: I5fc87b27a1d14e9e360c3835fcbf5db09322c674
---
M composer.lock
M extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php
M 
extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
M extensions/Wikibase/repo/includes/Notifications/ChangeNotifier.php
M extensions/Wikibase/repo/includes/WikibaseRepo.php
M 
extensions/Wikibase/repo/tests/phpunit/includes/Notifications/ChangeNotifierTest.php
M extensions/Wikibase/tests/browser/features/support/modules/alias_module.rb
M extensions/Wikibase/tests/browser/features/support/modules/sitelink_module.rb
M extensions/Wikibase/tests/browser/features/support/modules/statement_module.rb
M 
extensions/Wikibase/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
A 
extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.png
A 
extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.svg
M 
extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
M 
extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
M extensions/Wikibase/view/resources/templates.php
M vendor/composer/installed.json
16 files changed, 104 insertions(+), 89 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata 
refs/changes/18/312218/1

diff --git a/composer.lock b/composer.lock
index d850392..421f17e 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1574,12 +1574,12 @@
             "source": {
                 "type": "git",
                 "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
-                "reference": "15dc124a105eed6e385081c6975f120b06016633"
+                "reference": "152ffd88191a911c57dd130190c48df261e512e0"
             },
             "dist": {
                 "type": "zip",
-                "url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/15dc124a105eed6e385081c6975f120b06016633";,
-                "reference": "15dc124a105eed6e385081c6975f120b06016633",
+                "url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/152ffd88191a911c57dd130190c48df261e512e0";,
+                "reference": "152ffd88191a911c57dd130190c48df261e512e0",
                 "shasum": ""
             },
             "require": {
@@ -1653,7 +1653,7 @@
                 "wikibaserepo",
                 "wikidata"
             ],
-            "time": "2016-09-21 09:35:21"
+            "time": "2016-09-22 00:11:54"
         },
         {
             "name": "wikibase/wikimedia-badges",
diff --git 
a/extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php 
b/extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php
index 9d97ba8..0820dec 100644
--- a/extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php
+++ b/extensions/Wikibase/client/includes/Specials/SpecialEntityUsage.php
@@ -4,16 +4,19 @@
 
 use HTMLForm;
 use Html;
-use InvalidArgumentException;
 use Linker;
 use QueryPage;
 use Skin;
 use Title;
 use Wikibase\Client\Usage\EntityUsage;
-use Wikibase\DataModel\Entity\ItemId;
+use Wikibase\Client\WikibaseClient;
+use Wikibase\DataModel\Entity\EntityId;
+use Wikibase\DataModel\Entity\EntityIdParser;
+use Wikibase\DataModel\Entity\EntityIdParsingException;
 
 /**
- * Get usage of any given entity.
+ * A special page that lists client wiki pages that use a given entity ID from 
the repository, and
+ * which aspects each page uses.
  *
  * @since 0.5
  *
@@ -23,9 +26,14 @@
 class SpecialEntityUsage extends QueryPage {
 
        /**
-        * @var ItemId|null
+        * @var EntityIdParser
         */
-       private $entityId;
+       private $idParser;
+
+       /**
+        * @var EntityId|null
+        */
+       private $entityId = null;
 
        /**
         * @see SpecialPage::__construct
@@ -34,6 +42,9 @@
         */
        public function __construct( $name = 'EntityUsage' ) {
                parent::__construct( $name );
+
+               // TODO: Inject.
+               $this->idParser = 
WikibaseClient::getDefaultInstance()->getEntityIdParser();
        }
 
        /**
@@ -53,13 +64,16 @@
                }
        }
 
+       /**
+        * @param string $subPage
+        */
        private function prepareParams( $subPage ) {
                $entity = $this->getRequest()->getText( 'entity', $subPage );
 
                if ( $entity ) {
                        try {
-                               $this->entityId = new ItemId( $entity );
-                       } catch ( InvalidArgumentException $ex ) {
+                               $this->entityId = $this->idParser->parse( 
$entity );
+                       } catch ( EntityIdParsingException $ex ) {
                                $this->getOutput()->addHTML(
                                        Html::element(
                                                'p',
@@ -76,7 +90,7 @@
        /**
         * @see QueryPage::getPageHeader
         *
-        * @return string
+        * @return string HTML
         */
        public function getPageHeader() {
                $formDescriptor = [
@@ -141,26 +155,36 @@
         * @see QueryPage::formatResult
         *
         * @param Skin $skin
-        * @param object $result
+        * @param object $row
         *
-        * @return string
+        * @return string HTML
         */
        public function formatResult( $skin, $row ) {
                global $wgContLang;
 
                $title = Title::makeTitleSafe( $row->namespace, $row->title );
-               $aspects = $this->formatAspects( $row->aspects );
-               if ( $title instanceof Title ) {
-                       $text = $wgContLang->convert( $title->getPrefixedText() 
);
-                       return Linker::link( $title, htmlspecialchars( $text ) 
) . ': ' . $aspects;
-               } else {
-                       return Html::element( 'span', [ 'class' => 
'mw-invalidtitle' ],
-                               Linker::getInvalidTitleDescription( 
$this->getContext(), $row->namespace, $row->title ) );
+
+               if ( !$title ) {
+                       return Html::element(
+                               'span',
+                               [ 'class' => 'mw-invalidtitle' ],
+                               Linker::getInvalidTitleDescription(
+                                       $this->getContext(),
+                                       $row->namespace,
+                                       $row->title
+                               )
+                       );
                }
+
+               return Linker::link(
+                       $title,
+                       htmlspecialchars( $wgContLang->convert( 
$title->getPrefixedText() ) )
+               ) . ': ' . $this->formatAspects( $row->aspects );
        }
 
        /**
         * @param string $rowAspects
+        *
         * @return string
         */
        public function formatAspects( $rowAspects ) {
@@ -197,7 +221,7 @@
        /**
         * @see QueryPage::linkParameters
         *
-        * @return array
+        * @return string[]
         */
        public function linkParameters() {
                return [ 'entity' => $this->entityId->getSerialization() ];
diff --git 
a/extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
 
b/extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
index 7e5d933..e3daa05 100644
--- 
a/extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
+++ 
b/extensions/Wikibase/client/tests/phpunit/includes/Specials/SpecialEntityUsageTest.php
@@ -21,10 +21,6 @@
  */
 class SpecialEntityUsageTest extends SpecialPageTestBase {
 
-       protected function setUp() {
-               parent::setUp();
-       }
-
        public function reallyDoQueryMock() {
                $rows = [
                        (object)[
@@ -36,10 +32,13 @@
                                'eu_entity_id' => 'Q3',
                        ],
                ];
-               $res = new FakeResultWrapper( $rows );
-               return $res;
+
+               return new FakeResultWrapper( $rows );
        }
 
+       /**
+        * @return SpecialEntityUsage
+        */
        protected function newSpecialPage() {
                $specialPage = $this->getMockBuilder( SpecialEntityUsage::class 
)
                        ->setMethods( [ 'reallyDoQuery' ] )
diff --git a/extensions/Wikibase/repo/includes/Notifications/ChangeNotifier.php 
b/extensions/Wikibase/repo/includes/Notifications/ChangeNotifier.php
index 50ec107..65a1d0b 100644
--- a/extensions/Wikibase/repo/includes/Notifications/ChangeNotifier.php
+++ b/extensions/Wikibase/repo/includes/Notifications/ChangeNotifier.php
@@ -2,7 +2,6 @@
 
 namespace Wikibase\Repo\Notifications;
 
-use Hooks;
 use InvalidArgumentException;
 use Revision;
 use User;
@@ -64,13 +63,11 @@
                }
 
                $change = $this->changeFactory->newFromUpdate( 
EntityChange::REMOVE, $content->getEntity() );
-
                $change->setTimestamp( $timestamp );
                $change->setMetadataFromUser( $user );
 
                $this->transmitChange( $change );
 
-               Hooks::run( 'WikibaseChange', array( $change ) );
                return $change;
        }
 
@@ -102,7 +99,6 @@
 
                $this->transmitChange( $change );
 
-               Hooks::run( 'WikibaseChange', array( $change ) );
                return $change;
        }
 
@@ -127,7 +123,6 @@
                }
 
                $change = $this->changeFactory->newFromUpdate( 
EntityChange::ADD, null, $content->getEntity() );
-
                $change->setRevisionInfo( $revision );
 
                // FIXME: RepoHooks::onRecentChangeSave currently adds to the 
change later!
diff --git a/extensions/Wikibase/repo/includes/WikibaseRepo.php 
b/extensions/Wikibase/repo/includes/WikibaseRepo.php
index 8b6caf1..89f3209 100644
--- a/extensions/Wikibase/repo/includes/WikibaseRepo.php
+++ b/extensions/Wikibase/repo/includes/WikibaseRepo.php
@@ -109,7 +109,6 @@
 use Wikibase\Repo\Localizer\ParseExceptionLocalizer;
 use Wikibase\Repo\Modules\EntityTypesConfigValueProvider;
 use Wikibase\Repo\Notifications\ChangeNotifier;
-use Wikibase\Repo\Notifications\ChangeTransmitter;
 use Wikibase\Repo\Notifications\DatabaseChangeTransmitter;
 use Wikibase\Repo\Notifications\HookChangeTransmitter;
 use Wikibase\Repo\ParserOutput\DispatchingEntityViewFactory;
@@ -1189,30 +1188,18 @@
        }
 
        /**
-        * @return ChangeTransmitter[]
-        */
-       private function getChangeTransmitters() {
-               $transmitters = array();
-
-               $transmitters[] = new HookChangeTransmitter( 
'WikibaseChangeNotification' );
-
-               if ( $this->settings->getSetting( 'useChangesTable' ) ) {
-                       $transmitters[] = new DatabaseChangeTransmitter(
-                               $this->getStore()->getChangeStore()
-                       );
-               }
-
-               return $transmitters;
-       }
-
-       /**
         * @return ChangeNotifier
         */
        public function getChangeNotifier() {
-               return new ChangeNotifier(
-                       $this->getEntityChangeFactory(),
-                       $this->getChangeTransmitters()
-               );
+               $transmitters = [
+                       new HookChangeTransmitter( 'WikibaseChangeNotification' 
),
+               ];
+
+               if ( $this->settings->getSetting( 'useChangesTable' ) ) {
+                       $transmitters[] = new DatabaseChangeTransmitter( 
$this->getStore()->getChangeStore() );
+               }
+
+               return new ChangeNotifier( $this->getEntityChangeFactory(), 
$transmitters );
        }
 
        /**
diff --git 
a/extensions/Wikibase/repo/tests/phpunit/includes/Notifications/ChangeNotifierTest.php
 
b/extensions/Wikibase/repo/tests/phpunit/includes/Notifications/ChangeNotifierTest.php
index 8d1fbc5..b6621a0 100644
--- 
a/extensions/Wikibase/repo/tests/phpunit/includes/Notifications/ChangeNotifierTest.php
+++ 
b/extensions/Wikibase/repo/tests/phpunit/includes/Notifications/ChangeNotifierTest.php
@@ -34,12 +34,8 @@
                $changeTransmitter->expects( $this->exactly( 
$expectNotifications ) )
                        ->method( 'transmitChange' );
 
-               $notifier = new ChangeNotifier(
-                       
WikibaseRepo::getDefaultInstance()->getEntityChangeFactory(),
-                       array( $changeTransmitter )
-               );
-
-               return $notifier;
+               $changeFactory = 
WikibaseRepo::getDefaultInstance()->getEntityChangeFactory();
+               return new ChangeNotifier( $changeFactory, [ $changeTransmitter 
] );
        }
 
        /**
@@ -48,10 +44,7 @@
         * @return ItemContent
         */
        private function makeItemContent( ItemId $id ) {
-               $item = new Item( $id );
-
-               $content = ItemContent::newFromItem( $item );
-               return $content;
+               return ItemContent::newFromItem( new Item( $id ) );
        }
 
        /**
@@ -63,9 +56,7 @@
         */
        protected function makeItemRedirectContent( ItemId $id, ItemId $target 
) {
                $title = Title::newFromText( $target->getSerialization() );
-               $redirect = new EntityRedirect( $id, $target );
-               $content = ItemContent::newFromRedirect( $redirect, $title );
-               return $content;
+               return ItemContent::newFromRedirect( new EntityRedirect( $id, 
$target ), $title );
        }
 
        /**
@@ -78,7 +69,7 @@
         * @return Revision
         */
        private function makeRevision( Content $content, User $user, 
$revisionId, $timestamp, $parent_id = 0 ) {
-               $revision = new Revision( array(
+               return new Revision( [
                        'id' => $revisionId,
                        'page' => 7,
                        'content' => $content,
@@ -86,9 +77,7 @@
                        'user_text' => $user->getName(),
                        'timestamp' => $timestamp,
                        'parent_id' => $parent_id,
-               ) );
-
-               return $revision;
+               ] );
        }
 
        private function makeUser( $name ) {
diff --git 
a/extensions/Wikibase/tests/browser/features/support/modules/alias_module.rb 
b/extensions/Wikibase/tests/browser/features/support/modules/alias_module.rb
index 5821bbd..4642082 100644
--- a/extensions/Wikibase/tests/browser/features/support/modules/alias_module.rb
+++ b/extensions/Wikibase/tests/browser/features/support/modules/alias_module.rb
@@ -16,7 +16,7 @@
   text_field(:aliases_input_empty, xpath: "//div[contains(@class, 
'wikibase-aliasesview')]//li[contains(@class, 'tagadata-choice-empty')]//input")
   text_field(:aliases_input_modified, xpath: "//div[contains(@class, 
'wikibase-aliasesview')]//li[contains(@class, 
'tagadata-choice-modified')]//input")
   text_field(:aliases_input_equal, xpath: "//div[contains(@class, 
'wikibase-aliasesview')]//li[contains(@class, 'tagadata-choice-equal')]//input")
-  span(:aliases_help_field, css: 'div.wikibase-aliasesview 
span.mw-help-field-hint')
+  span(:aliases_help_field, css: 'div.wikibase-aliasesview 
span.wb-help-field-hint')
 
   # aliases methods
   def aliases_array
diff --git 
a/extensions/Wikibase/tests/browser/features/support/modules/sitelink_module.rb 
b/extensions/Wikibase/tests/browser/features/support/modules/sitelink_module.rb
index 5e10245..6d0a01d 100644
--- 
a/extensions/Wikibase/tests/browser/features/support/modules/sitelink_module.rb
+++ 
b/extensions/Wikibase/tests/browser/features/support/modules/sitelink_module.rb
@@ -33,7 +33,7 @@
   a(:edit_sitelink_link_en, css: "div[data-wb-sitelinks-group='wikipedia'] 
table tr.wikibase-sitelinkview-enwiki 
span.wikibase-toolbar-button-edit:not(.wikibase-toolbarbutton-disabled) > a")
   a(:edit_sitelink_link_en_disabled, css: 
"div[data-wb-sitelinks-group='wikipedia'] table tr.wikibase-sitelinkview-enwiki 
span.wikibase-toolbar-button-edit.wikibase-toolbarbutton-disabled > a")
   h1(:article_title, xpath: "//h1[contains(@class, 'firstHeading')]")
-  span(:sitelink_help_field, css: "div[data-wb-sitelinks-group='wikipedia'] 
.wikibase-toolbar-container span.mw-help-field-hint")
+  span(:sitelink_help_field, css: "div[data-wb-sitelinks-group='wikipedia'] 
.wikibase-toolbar-container span.wb-help-field-hint")
 
   indexed_property(:sitelinks_form, [
     [:text_field, :site_id_input_field, { css: 
"div[data-wb-sitelinks-group='wikipedia'] ul li:nth-child(%s) 
span.wikibase-sitelinkview-siteid input" }],
diff --git 
a/extensions/Wikibase/tests/browser/features/support/modules/statement_module.rb
 
b/extensions/Wikibase/tests/browser/features/support/modules/statement_module.rb
index b56a10e..aba3011 100644
--- 
a/extensions/Wikibase/tests/browser/features/support/modules/statement_module.rb
+++ 
b/extensions/Wikibase/tests/browser/features/support/modules/statement_module.rb
@@ -23,7 +23,7 @@
   a(:save_statement_disabled, css: '.wikibase-statementlistview 
div.listview-item 
span.wikibase-toolbar-button-save.wikibase-toolbarbutton-disabled > a')
   a(:cancel_statement, css: '.wikibase-statementlistview div.listview-item 
span.wikibase-toolbar-button-cancel:not(.wikibase-toolbarbutton-disabled) > a')
   a(:cancel_statement_disabled, css: '.wikibase-statementlistview 
div.listview-item 
span.wikibase-toolbar-button-cancel.wikibase-toolbarbutton-disabled > a')
-  span(:statement_help_field, css: 'div.wikibase-statementlistview 
span.mw-help-field-hint')
+  span(:statement_help_field, css: 'div.wikibase-statementlistview 
span.wb-help-field-hint')
   div(:claim_edit_mode, css: '.wb-claim-section div.wb-edit')
   textarea(:claim_value_input_field, css: 'div.wikibase-statementview-mainsnak 
.valueview-input')
 
diff --git 
a/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
index d455a87..b92e100 100644
--- 
a/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
+++ 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
@@ -308,7 +308,7 @@
                }
 
                this._$tooltipAnchor = $( '<span/>', {
-                       'class': 'mw-help-field-hint',
+                       'class': 'wb-help-field-hint',
                        html: '&nbsp;' // TODO find nicer way to hack Webkit 
browsers to display tooltip image (see also css)
                } ).toolbaritem();
 
diff --git 
a/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.png
 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.png
new file mode 100644
index 0000000..c9933da
--- /dev/null
+++ 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.png
Binary files differ
diff --git 
a/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.svg
 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.svg
new file mode 100644
index 0000000..1e2f039
--- /dev/null
+++ 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/images/help-question.svg
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<svg xmlns="http://www.w3.org/2000/svg"; width="11" height="111">
+<rect style="fill:#ffffff;stroke:#4d4d4d" width="10" height="10" x="0.5" 
y="0.5" ry="0.5" />
+<path style="fill:#000000" d="M 5.4473626,5.6073306 C 5.563295,5.5195074 
5.7589374,5.3846312 6.0342904,5.2027014 6.3168806,5.0145056 6.537884,4.8608094 
6.6973015,4.7416122 6.8639547,4.6224234 7.0197441,4.4655905 7.16467,4.2711131 
7.3095847,4.0703716 7.3820449,3.8696255 7.3820507,3.6688742 7.3820449,3.380307 
7.2624856,3.151331 7.0233725,2.9819456 6.7914946,2.8062986 6.494408,2.7184723 
6.1321117,2.7184661 5.2625854,2.7184723 4.635805,3.1764243 4.2517689,4.0923235 
L 3.2952939,3.9888136 C 3.7952672,2.6902423 4.7952173,2.0409543 
6.2951472,2.0409474 6.9182998,2.0409543 7.4218979,2.1664205 7.8059429,2.4173467 
8.1899755,2.6620124 8.381995,3.0101814 8.3820017,3.4618547 8.381995,3.7567059 
8.2986658,4.0358684 8.1320139,4.299343 7.9653491,4.5565536 7.7769527,4.763573 
7.5668242,4.9204019 7.3639298,5.0709654 7.1139423,5.2528915 6.8168608,5.4661808 
6.5197691,5.679477 6.2987656,5.8551298 6.1538498,5.9931398 5.8495126,6.2879886 
5.6248861,6.7020273 5.4799697,7.2352575 l -0.967344,0 0.097821,-0.3858093 C 
4.6756581,6.5985176 4.7915944,6.3601317 4.958256,6.1342895 5.1321571,5.9021797 
5.2951924,5.7265269 5.4473626,5.6073306 M 4.0561263,8.8914143 
4.284376,7.9504161 l 1.0869034,0 -0.2282498,0.9409982 -1.0869033,0" />
+<rect ry="0.5" y="100.5" x="0.5" height="10" width="10" 
style="fill:#ffffff;stroke:#0645ad" />
+<path style="fill:#0645ad" d="m 5.4473629,105.60733 c 0.1159327,-0.0878 
0.3115752,-0.2227 0.5869285,-0.40463 0.2825895,-0.18819 0.5035936,-0.34189 
0.6630111,-0.46109 0.1666525,-0.11919 0.3224417,-0.27602 0.4673685,-0.4705 
0.144914,-0.20074 0.2173747,-0.40148 0.2173801,-0.60224 -5.4e-6,-0.28856 
-0.1195653,-0.51754 -0.3586775,-0.68692 -0.2318782,-0.17565 -0.5289648,-0.26348 
-0.891261,-0.26348 -0.8695266,0 -1.4963073,0.45795 -1.8803431,1.37385 l 
-0.9564747,-0.10351 c 0.4999728,-1.29857 1.4999226,-1.94786 2.9998529,-1.94786 
0.6231523,0 1.1267513,0.12547 1.5107957,0.3764 0.3840327,0.24466 
0.5760522,0.59283 0.5760586,1.0445 -6.4e-6,0.29486 -0.083335,0.57402 
-0.2499874,0.83749 -0.1666644,0.25721 -0.355061,0.46423 -0.5651898,0.62106 
-0.2028948,0.15057 -0.4528823,0.33249 -0.7499635,0.54578 -0.297092,0.2133 
-0.518095,0.38895 -0.6630111,0.52696 -0.3043368,0.29485 -0.5289637,0.70889 
-0.6738798,1.24212 l -0.9673446,0 0.097822,-0.38581 c 0.065215,-0.25093 
0.1811464,-0.48932 0.3478087,-0.71516 0.1739006,-0.23211 0.3369367,-0.40776 
0.4891061,-0.52696 m -1.3912359,3.28408 0.2282499,-0.94099 1.0869035,0 
-0.2282499,0.94099 -1.0869035,0" />
+</svg>
diff --git 
a/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
index cc96b13..31e5daa 100644
--- 
a/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
+++ 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css
@@ -1,7 +1,29 @@
 /**
  * @license GNU GPL v2+
  * @author H. Snater < mediaw...@snater.com >
+ * @author Thiemo M├Ąttig
  */
 .wikibase-edittoolbar-container > .wikibase-toolbar {
        padding-left: 0;
 }
+
+/* This is partially copied from core's 
resources/src/mediawiki.legacy/shared.css. */
+.wb-help-field-hint {
+       /* SVG support using a transparent gradient to guarantee cross-browser
+        * compatibility (browsers able to understand gradient syntax support 
also SVG).
+        * 
http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique */
+       background-image: url(images/help-question.png);
+       background-image: linear-gradient(transparent, transparent), 
url(images/help-question.svg);
+       background-position: 0 0;
+       background-repeat: no-repeat;
+       cursor: pointer;
+       display: inline-block;
+       height: 11px;
+       margin-left: 3px;
+       vertical-align: middle;
+       width: 11px;
+}
+
+.wb-help-field-hint:hover {
+       background-position: 0 -100px;
+}
diff --git 
a/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
index 623a0e3..fcfafec 100644
--- 
a/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
+++ 
b/extensions/Wikibase/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css
@@ -7,14 +7,6 @@
        color: grey;
 }
 
-.wikibase-toolbar-item .mw-help-field-hint {
-       display: inline-block;
-       margin-left: 3px;
-       padding: 0;
-       text-decoration: none;
-       min-width: 11px;
-}
-
 .wikibase-toolbar-item .mw-collapsible-toggle {
        background-position: right;
        background-repeat: no-repeat;
diff --git a/extensions/Wikibase/view/resources/templates.php 
b/extensions/Wikibase/view/resources/templates.php
index 138e08a..2b1fd34 100644
--- a/extensions/Wikibase/view/resources/templates.php
+++ b/extensions/Wikibase/view/resources/templates.php
@@ -330,7 +330,7 @@
 <<<HTML
 <div class="wikibase-pageImage">
        <div class="help">
-               <span class="mw-help-field-hint wikibase-toolbar-item 
wikibase-wbtooltip" title="$1">&nbsp;</span>
+               <span class="wb-help-field-hint wikibase-toolbar-item 
wikibase-wbtooltip" title="$1">&nbsp;</span>
        </div>
 </div>
 HTML;
diff --git a/vendor/composer/installed.json b/vendor/composer/installed.json
index e9b937b..74edd78 100644
--- a/vendor/composer/installed.json
+++ b/vendor/composer/installed.json
@@ -1354,12 +1354,12 @@
         "source": {
             "type": "git",
             "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
-            "reference": "15dc124a105eed6e385081c6975f120b06016633"
+            "reference": "152ffd88191a911c57dd130190c48df261e512e0"
         },
         "dist": {
             "type": "zip",
-            "url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/15dc124a105eed6e385081c6975f120b06016633";,
-            "reference": "15dc124a105eed6e385081c6975f120b06016633",
+            "url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/152ffd88191a911c57dd130190c48df261e512e0";,
+            "reference": "152ffd88191a911c57dd130190c48df261e512e0",
             "shasum": ""
         },
         "require": {
@@ -1392,7 +1392,7 @@
             "jakub-onderka/php-parallel-lint": "0.9.2",
             "mediawiki/mediawiki-codesniffer": "0.4.0|0.5.0"
         },
-        "time": "2016-09-21 09:35:21",
+        "time": "2016-09-22 00:11:54",
         "type": "mediawiki-extension",
         "installation-source": "dist",
         "autoload": {

-- 
To view, visit https://gerrit.wikimedia.org/r/312218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fc87b27a1d14e9e360c3835fcbf5db09322c674
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: WikidataBuilder <wikidata-servi...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to