Jack Phoenix has submitted this change and it was merged.

Change subject: Remove external link icons in favor of using the core RL module
......................................................................


Remove external link icons in favor of using the core RL module

Bug: T146250
Change-Id: I2932d63d40d60680be0aecf71835a4b106e33dae
---
M DeepSea.skin.php
D deepsea/images/audio-icon.png
D deepsea/images/document-icon.png
D deepsea/images/external-link-ltr-icon.png
D deepsea/images/external-link-rtl-icon.png
D deepsea/images/file-icon.png
D deepsea/images/link-icon.png
D deepsea/images/lock-icon.png
D deepsea/images/mail-icon.png
D deepsea/images/news-icon.png
D deepsea/images/talk-icon.png
D deepsea/images/user-icon.png
D deepsea/images/video-icon.png
M deepsea/screen.css
14 files changed, 4 insertions(+), 70 deletions(-)

Approvals:
  Jack Phoenix: Verified; Looks good to me, approved



diff --git a/DeepSea.skin.php b/DeepSea.skin.php
index 757d6f7..49a2288 100644
--- a/DeepSea.skin.php
+++ b/DeepSea.skin.php
@@ -43,6 +43,7 @@
                parent::setupSkinUserCss( $out );
                $out->addModuleStyles( array(
                        'mediawiki.skinning.interface',
+                       'mediawiki.skinning.content.externallinks',
                        'skins.deepsea'
                ) );
 
diff --git a/deepsea/images/audio-icon.png b/deepsea/images/audio-icon.png
deleted file mode 100644
index ffd0b1c..0000000
--- a/deepsea/images/audio-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/document-icon.png b/deepsea/images/document-icon.png
deleted file mode 100644
index 7b68120..0000000
--- a/deepsea/images/document-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/external-link-ltr-icon.png 
b/deepsea/images/external-link-ltr-icon.png
deleted file mode 100644
index fe642b5..0000000
--- a/deepsea/images/external-link-ltr-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/external-link-rtl-icon.png 
b/deepsea/images/external-link-rtl-icon.png
deleted file mode 100644
index 01e0d79..0000000
--- a/deepsea/images/external-link-rtl-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/file-icon.png b/deepsea/images/file-icon.png
deleted file mode 100644
index 8a4baf2..0000000
--- a/deepsea/images/file-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/link-icon.png b/deepsea/images/link-icon.png
deleted file mode 100644
index 469fd2b..0000000
--- a/deepsea/images/link-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/lock-icon.png b/deepsea/images/lock-icon.png
deleted file mode 100644
index 46b72f5..0000000
--- a/deepsea/images/lock-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/mail-icon.png b/deepsea/images/mail-icon.png
deleted file mode 100644
index a8ad2fd..0000000
--- a/deepsea/images/mail-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/news-icon.png b/deepsea/images/news-icon.png
deleted file mode 100644
index bb03a89..0000000
--- a/deepsea/images/news-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/talk-icon.png b/deepsea/images/talk-icon.png
deleted file mode 100644
index 12862a0..0000000
--- a/deepsea/images/talk-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/user-icon.png b/deepsea/images/user-icon.png
deleted file mode 100644
index a3b38b3..0000000
--- a/deepsea/images/user-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/images/video-icon.png b/deepsea/images/video-icon.png
deleted file mode 100644
index 06bc9b6..0000000
--- a/deepsea/images/video-icon.png
+++ /dev/null
Binary files differ
diff --git a/deepsea/screen.css b/deepsea/screen.css
index bccb00b..e1c8245 100644
--- a/deepsea/screen.css
+++ b/deepsea/screen.css
@@ -730,71 +730,6 @@
        padding-top: 0;
        font-size: 1.6em;
 }
-div#content a.external,
-div#content a.external[href ^="gopher://";] {
-       /* @embed */
-       background: url(images/external-link-ltr-icon.png) center right 
no-repeat;
-       padding-right: 13px;
-}
-div#content a.external[href ^="https://";],
-.link-https {
-       /* @embed */
-       background: url(images/lock-icon.png) center right no-repeat;
-       padding-right: 13px;
-}
-div#content a.external[href ^="mailto:";],
-.link-mailto {
-       /* @embed */
-       background: url(images/mail-icon.png) center right no-repeat;
-       padding-right: 13px;
-}
-div#content a.external[href ^="news:";] {
-       /* @embed */
-       background: url(images/news-icon.png) center right no-repeat;
-       padding-right: 13px;
-}
-div#content a.external[href ^="ftp://";],
-.link-ftp {
-       /* @embed */
-       background: url(images/file-icon.png) center right no-repeat;
-       padding-right: 13px;
-}
-div#content a.external[href ^="irc://"],
-div#content a.external[href ^="ircs://"],
-.link-irc {
-       /* @embed */
-       background: url(images/talk-icon.png) center right no-repeat;
-       padding-right: 13px;
-}
-div#content a.external[href $=".ogg"], div#content a.external[href $=".OGG"],
-div#content a.external[href $=".mid"], div#content a.external[href $=".MID"],
-div#content a.external[href $=".midi"], div#content a.external[href $=".MIDI"],
-div#content a.external[href $=".mp3"], div#content a.external[href $=".MP3"],
-div#content a.external[href $=".wav"], div#content a.external[href $=".WAV"],
-div#content a.external[href $=".wma"], div#content a.external[href $=".WMA"],
-.link-audio {
-       /* @embed */
-       background: url(images/audio-icon.png) center right no-repeat;
-       padding-right: 13px;
-}
-div#content a.external[href $=".ogm"], div#content a.external[href $=".OGM"],
-div#content a.external[href $=".avi"], div#content a.external[href $=".AVI"],
-div#content a.external[href $=".mpeg"], div#content a.external[href $=".MPEG"],
-div#content a.external[href $=".mpg"], div#content a.external[href $=".MPG"],
-.link-video {
-       /* @embed */
-       background: url(images/video-icon.png) center right no-repeat;
-       padding-right: 13px;
-}
-div#content a.external[href $=".pdf"], div#content a.external[href $=".PDF"],
-div#content a.external[href *=".pdf#"], div#content a.external[href *=".PDF#"],
-div#content a.external[href *=".pdf?"], div#content a.external[href *=".PDF?"],
-.link-document {
-       /* @embed */
-       background: url(images/document-icon.png) center right no-repeat;
-       padding-right: 13px;
-}
-
 div#content .printfooter {
        display: none;
 }
@@ -802,8 +737,6 @@
 #pt-userpage,
 #pt-anonuserpage,
 #pt-login {
-       /* @embed */
-       /*background: url(images/user-icon.png) left center no-repeat;*/
        padding-left: 15px !important;
        text-transform: none;
 }
@@ -882,16 +815,16 @@
 }
 
 /* Typography refresh */
- 
+
 h1, h2, h3, h4, h5, h6 {
        font-family: "Lato", "Helvetica", "Arial", sans-serif;
        line-height: 1.3;
 }
- 
+
 h1, h2 {
        border-color: #ddd;
 }
- 
+
 h2, h3 {
        font-weight: bold !important;
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/311984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2932d63d40d60680be0aecf71835a4b106e33dae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/DeepSea
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to