Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312321
Change subject: Remove js-truncation of descriptions in Special:Notifications
desktop
......................................................................
Remove js-truncation of descriptions in Special:Notifications desktop
In order for the special page to be responsive, the descriptions can't
be truncated in the JS. If they are, they take a bigger portion
of the screen, sometimes going out of its confines.
The popup should still truncate descriptions.
Change-Id: I533f29c00482f6cfbb7b1c9c7417715e3c5809bf
(cherry picked from commit a834420533c475a431d4104fd131589eda728e2f)
---
M modules/styles/mw.echo.ui.NotificationItemWidget.less
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/21/312321/1
diff --git a/modules/styles/mw.echo.ui.NotificationItemWidget.less
b/modules/styles/mw.echo.ui.NotificationItemWidget.less
index b2df7c0..91de5f2 100644
--- a/modules/styles/mw.echo.ui.NotificationItemWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationItemWidget.less
@@ -61,11 +61,11 @@
color: @notification-text-color;
}
&-body {
- @media all and ( min-width:
@specialpage-hd-width ) {
- // Don't truncate on small screens
+ // In the popup only, truncate the text to
one-line
+ // with ellipses
+
.mw-echo-ui-notificationBadgeButtonPopupWidget-popup & {
.mw-echo-ui-mixin-one-line-truncated;
}
-
color: @notification-body-color;
margin-top: 4px;
}
--
To view, visit https://gerrit.wikimedia.org/r/312321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I533f29c00482f6cfbb7b1c9c7417715e3c5809bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.28.0-wmf.18
Gerrit-Owner: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
