Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/312325

Change subject: Add 'canRender' check to EchoMentionStatusPresentationModel
......................................................................

Add 'canRender' check to EchoMentionStatusPresentationModel

Change-Id: Ica338ff5810b62849d30e5b27709558f1b797c43
(cherry picked from commit eb98b21dfef8f86184801120725df266c40ea4aa)
---
M includes/formatters/MentionStatusPresentationModel.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/25/312325/1

diff --git a/includes/formatters/MentionStatusPresentationModel.php 
b/includes/formatters/MentionStatusPresentationModel.php
index 2168fbc..d6366e0 100644
--- a/includes/formatters/MentionStatusPresentationModel.php
+++ b/includes/formatters/MentionStatusPresentationModel.php
@@ -20,6 +20,10 @@
                return 'mention-failure';
        }
 
+       public function canRender() {
+               return (bool)$this->event->getTitle();
+       }
+
        public function getHeaderMessage() {
                if ( $this->isTooManyMentionsFailure() ) {
                        $msg = $this->getMessageWithAgent( 
'notification-header-mention-failure-too-many' );

-- 
To view, visit https://gerrit.wikimedia.org/r/312325
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica338ff5810b62849d30e5b27709558f1b797c43
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.28.0-wmf.18
Gerrit-Owner: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to