jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: encapsulate SearchCardView's callback
......................................................................


Hygiene: encapsulate SearchCardView's callback

Change-Id: Icf476bca12b3b8901acd781e2e1283770a8c93d8
---
M app/src/main/java/org/wikipedia/feed/searchbar/SearchCardView.java
M app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java
2 files changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/feed/searchbar/SearchCardView.java 
b/app/src/main/java/org/wikipedia/feed/searchbar/SearchCardView.java
index 82348f5..184e871 100644
--- a/app/src/main/java/org/wikipedia/feed/searchbar/SearchCardView.java
+++ b/app/src/main/java/org/wikipedia/feed/searchbar/SearchCardView.java
@@ -10,6 +10,11 @@
 import butterknife.OnClick;
 
 public class SearchCardView extends DefaultFeedCardView<SearchCard> {
+    public interface Callback {
+        void onSearchRequested();
+        void onVoiceSearchRequested();
+    }
+
     public SearchCardView(Context context) {
         super(context);
         inflate(getContext(), R.layout.view_search_bar, this);
diff --git a/app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java 
b/app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java
index f29a75a..d1323f3 100644
--- a/app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java
+++ b/app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java
@@ -4,11 +4,11 @@
 
 import org.wikipedia.feed.image.FeaturedImageCardView;
 import org.wikipedia.feed.news.NewsItemCard;
+import org.wikipedia.feed.searchbar.SearchCardView;
 import org.wikipedia.views.ItemTouchHelperSwipeAdapter;
 
 public interface FeedViewCallback extends ItemTouchHelperSwipeAdapter.Callback,
-        PageTitleListCardItemView.Callback, CardHeaderView.Callback, 
FeaturedImageCardView.Callback {
-    void onSearchRequested();
-    void onVoiceSearchRequested();
+        PageTitleListCardItemView.Callback, CardHeaderView.Callback, 
FeaturedImageCardView.Callback,
+        SearchCardView.Callback {
     void onNewsItemSelected(@NonNull NewsItemCard card);
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/312145
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf476bca12b3b8901acd781e2e1283770a8c93d8
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to