jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: encapsulate NewsListCardView's callback
......................................................................


Hygiene: encapsulate NewsListCardView's callback

Change-Id: I63539c2a7f2c351f8da0b1c0b46e1764fc224419
---
M app/src/main/java/org/wikipedia/feed/news/NewsListCardView.java
M app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java
2 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/feed/news/NewsListCardView.java 
b/app/src/main/java/org/wikipedia/feed/news/NewsListCardView.java
index 6ae01e5..17affef 100644
--- a/app/src/main/java/org/wikipedia/feed/news/NewsListCardView.java
+++ b/app/src/main/java/org/wikipedia/feed/news/NewsListCardView.java
@@ -18,6 +18,9 @@
 
 public class NewsListCardView extends 
HorizontalScrollingListCardView<NewsListCard>
         implements ItemTouchHelperSwipeAdapter.SwipeableView {
+    public interface Callback {
+        void onNewsItemSelected(@NonNull NewsItemCard card);
+    }
 
     public NewsListCardView(@NonNull Context context) {
         super(context);
diff --git a/app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java 
b/app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java
index d1323f3..323eb86 100644
--- a/app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java
+++ b/app/src/main/java/org/wikipedia/feed/view/FeedViewCallback.java
@@ -1,14 +1,11 @@
 package org.wikipedia.feed.view;
 
-import android.support.annotation.NonNull;
-
 import org.wikipedia.feed.image.FeaturedImageCardView;
-import org.wikipedia.feed.news.NewsItemCard;
+import org.wikipedia.feed.news.NewsListCardView;
 import org.wikipedia.feed.searchbar.SearchCardView;
 import org.wikipedia.views.ItemTouchHelperSwipeAdapter;
 
 public interface FeedViewCallback extends ItemTouchHelperSwipeAdapter.Callback,
         PageTitleListCardItemView.Callback, CardHeaderView.Callback, 
FeaturedImageCardView.Callback,
-        SearchCardView.Callback {
-    void onNewsItemSelected(@NonNull NewsItemCard card);
+        SearchCardView.Callback, NewsListCardView.Callback {
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/312146
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63539c2a7f2c351f8da0b1c0b46e1764fc224419
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to