jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: remove redundant code from FeedView
......................................................................


Hygiene: remove redundant code from FeedView

Remove programmatic configuration of minColumnWidth. This attribute is
set in XML.

Change-Id: I8d13a7cc27a4b1a103e5eff1796a357e13a7d900
---
M app/src/main/java/org/wikipedia/feed/view/FeedView.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/feed/view/FeedView.java 
b/app/src/main/java/org/wikipedia/feed/view/FeedView.java
index 50d20d2..69336d6 100644
--- a/app/src/main/java/org/wikipedia/feed/view/FeedView.java
+++ b/app/src/main/java/org/wikipedia/feed/view/FeedView.java
@@ -56,7 +56,6 @@
 
     private void init() {
         setVerticalScrollBarEnabled(true);
-        minColumnWidth((int) 
getResources().getDimension(R.dimen.view_feed_min_column_width));
         recyclerLayoutManager = new StaggeredGridLayoutManager(getColumns(),
                 StaggeredGridLayoutManager.VERTICAL);
         setLayoutManager(recyclerLayoutManager);
@@ -105,4 +104,4 @@
             recyclerLayoutManager.setSpanCount(columns);
         }
     }
-}
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/312060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d13a7cc27a4b1a103e5eff1796a357e13a7d900
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to