Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/312431

Change subject: Improve documentation/parameter names of openPopup method
......................................................................

Improve documentation/parameter names of openPopup method

Change-Id: Ia2db8a0de3466556c08e64ae01829d6d9d426e72
---
M resources/ext.popups.renderer/desktopRenderer.js
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/31/312431/1

diff --git a/resources/ext.popups.renderer/desktopRenderer.js 
b/resources/ext.popups.renderer/desktopRenderer.js
index 7e24c13..169de9c 100644
--- a/resources/ext.popups.renderer/desktopRenderer.js
+++ b/resources/ext.popups.renderer/desktopRenderer.js
@@ -191,15 +191,15 @@
         * Takes care of event logging and attaching other events.
         *
         * @method openPopup
-        * @param {Object} link
-        * @param {Object} event
+        * @param {jQuery.Object} $link
+        * @param {jQuery.Event} event
         */
-       mw.popups.render.openPopup = function ( link, event ) {
+       mw.popups.render.openPopup = function ( $link, event ) {
                var
-                       cache = mw.popups.render.cache [ link.attr( 'href' ) ],
+                       cache = mw.popups.render.cache [ $link.attr( 'href' ) ],
                        popup = cache.popup,
-                       offset = cache.getOffset( link, event ),
-                       classes = cache.getClasses( link );
+                       offset = cache.getOffset( $link, event ),
+                       classes = cache.getClasses( $link );
 
                mw.popups.$popup
                        .html( '' )
@@ -229,11 +229,11 @@
                        perceivedWait: Math.round( mw.now() - 
logData.dwellStartTime )
                } );
 
-               cache.process( link, $.extend( {}, logData ) );
+               cache.process( $link, $.extend( {}, logData ) );
 
                mw.popups.$popup.find( 'a.mwe-popups-extract, 
a.mwe-popups-discreet' ).click( mw.popups.render.clickHandler );
 
-               link
+               $link
                        .off( 'mouseleave blur', mw.popups.render.leaveInactive 
)
                        .on( 'mouseleave blur', mw.popups.render.leaveActive );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/312431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2db8a0de3466556c08e64ae01829d6d9d426e72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to