jenkins-bot has submitted this change and it was merged.

Change subject: Use "X" icon for home-as-up button in PageActivity.
......................................................................


Use "X" icon for home-as-up button in PageActivity.

Bug: T145910
Change-Id: I6f40890fba7dde296e354270f120000d491d0285
---
M app/src/main/res/layout/activity_page.xml
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Mholloway: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/res/layout/activity_page.xml 
b/app/src/main/res/layout/activity_page.xml
index d4db551..9f2721e 100644
--- a/app/src/main/res/layout/activity_page.xml
+++ b/app/src/main/res/layout/activity_page.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout
     xmlns:android="http://schemas.android.com/apk/res/android";
+    xmlns:app="http://schemas.android.com/apk/res-auto";
     xmlns:tools="http://schemas.android.com/tools";
     android:id="@+id/activity_page_container"
     android:layout_width="match_parent"
@@ -54,7 +55,8 @@
                 android:theme="@style/AppTheme.ToolbarTheme"
                 android:id="@+id/page_toolbar"
                 android:layout_width="match_parent"
-                android:layout_height="?attr/actionBarSize">
+                android:layout_height="?attr/actionBarSize"
+                app:navigationIcon="@drawable/ic_close_white_24dp">
             </android.support.v7.widget.Toolbar>
             <ProgressBar
                 android:id="@+id/page_progress_bar"

-- 
To view, visit https://gerrit.wikimedia.org/r/312861
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f40890fba7dde296e354270f120000d491d0285
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to