Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313226
Change subject: feature-page-action-bar-v2 class is no longer necessary
......................................................................
feature-page-action-bar-v2 class is no longer necessary
This feature is stable.
Bug: T146912
change-Id: I75b05df254d7f569285c56950fe15ef7ebc08d0c
---
M includes/MobileFrontend.hooks.php
M resources/skins.minerva.base.styles/pageactions.less
2 files changed, 19 insertions(+), 28 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/26/313226/1
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index d790c9e..58e1cb9 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -1287,8 +1287,6 @@
$context = MobileContext::singleton();
$config = $context->getMFConfig();
- $bodyAttributes['class'] .= ' feature-page-action-bar-v2';
-
if ( $config->get( 'MinervaUseFooterV2' ) ||
$context->isBetaGroupMember() ) {
$bodyAttributes['class'] .= ' feature-footer-v2';
}
diff --git a/resources/skins.minerva.base.styles/pageactions.less
b/resources/skins.minerva.base.styles/pageactions.less
index 35b434c..7cd0c38 100644
--- a/resources/skins.minerva.base.styles/pageactions.less
+++ b/resources/skins.minerva.base.styles/pageactions.less
@@ -86,19 +86,6 @@
// On small devices that don't support Javascript, hide the page actions bar
@media all and ( max-width: @wgMFDeviceWidthMobileSmall ) {
- .client-nojs {
- #page-actions {
- display: none;
- }
-
- #section_0 {
- border: 0;
- }
- }
-}
-
-// FIXME: Merge these styles with those above as part of T130849.
-.feature-page-action-bar-v2 {
.heading-holder {
@pageActionsHeight: @pageActionFontSize + (2 *
@iconGutterWidth);
@@ -112,10 +99,8 @@
float: none;
bottom: 0;
width: 100%;
-
border-top: 1px solid @colorGray14;
border-bottom: 1px solid @colorGray12;
-
padding: 0.5em 0;
li {
@@ -142,20 +127,28 @@
margin-right: -@iconGutterWidth;
}
}
+
+ .client-nojs {
+ #page-actions {
+ display: none;
+ }
+
+ #section_0 {
+ border: 0;
+ }
+ }
}
@media all and ( min-width: @deviceWidthTablet ) {
- .feature-page-action-bar-v2 {
- #page-actions {
- position: initial;
- float: right;
- width: auto;
- border: 0;
- margin: 0 0 @iconGutterWidth @iconGutterWidth;
- }
+ #page-actions {
+ position: initial;
+ float: right;
+ width: auto;
+ border: 0;
+ margin: 0 0 @iconGutterWidth @iconGutterWidth;
+ }
- .language-selector {
- float: none;
- }
+ .language-selector {
+ float: none;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/313226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75b05df254d7f569285c56950fe15ef7ebc08d0c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
