jenkins-bot has submitted this change and it was merged.
Change subject: Load module 'mediawiki.diff.styles' on show changes
......................................................................
Load module 'mediawiki.diff.styles' on show changes
The loading of the diff styles get lost in 6627f2cd.
In MediaWiki 1.28 the name of the module was renamed from
'mediawiki.action.history.diff' to 'mediawiki.diff.styles'.
Bug: T142845
Change-Id: I86ed2a0568c6bc4e81819633a295cec2e8924215
---
M modules/jquery.wikiEditor.preview.js
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Fomafix: Looks good to me, but someone else must approve
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.wikiEditor.preview.js
b/modules/jquery.wikiEditor.preview.js
index 00edd40..754414b 100644
--- a/modules/jquery.wikiEditor.preview.js
+++ b/modules/jquery.wikiEditor.preview.js
@@ -118,11 +118,12 @@
rvprop: '',
rvsection: section === '' ?
undefined : section
};
+ var postPromise = api.post( postdata );
- api.post( postdata )
- .done( function ( data ) {
+ $.when( postPromise, mw.loader.using(
'mediawiki.diff.styles' ) )
+ .done( function ( postResult ) {
try {
- var diff =
data.query.pages[ 0 ]
+ var diff = postResult[
0 ].query.pages[ 0 ]
.revisions[ 0
].diff.body;
context.$changesTab.find( 'table.diff tbody' )
--
To view, visit https://gerrit.wikimedia.org/r/308759
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86ed2a0568c6bc4e81819633a295cec2e8924215
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Fomafix <[email protected]>
Gerrit-Reviewer: Fomafix <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
