BBlack has submitted this change and it was merged.

Change subject: VCL commentary
......................................................................


VCL commentary

Change-Id: I2f67fec9758496dff29e3f04aa4de081e3720ee1
---
M modules/varnish/templates/vcl/wikimedia-common.inc.vcl.erb
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  BBlack: Verified; Looks good to me, approved



diff --git a/modules/varnish/templates/vcl/wikimedia-common.inc.vcl.erb 
b/modules/varnish/templates/vcl/wikimedia-common.inc.vcl.erb
index bf6224d..e4b1eaa 100644
--- a/modules/varnish/templates/vcl/wikimedia-common.inc.vcl.erb
+++ b/modules/varnish/templates/vcl/wikimedia-common.inc.vcl.erb
@@ -348,6 +348,7 @@
                set beresp.ttl = 0s;
                /* This should be translated into hit_for_pass later */
        }
+       // This should probably be only 404 XXX
        elsif (beresp.status >= 400 && beresp.status <= 499 && beresp.ttl > 
10m) {
                set beresp.ttl = 10m;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/313801
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f67fec9758496dff29e3f04aa4de081e3720ee1
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
Gerrit-Reviewer: Ema <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to