jenkins-bot has submitted this change and it was merged. Change subject: Exception fix to Converter ......................................................................
Exception fix to Converter * Don't output error for normal 'end of list' cases. Change-Id: I803458b2383a0ac7f091a0a8d3417ff444a3be4c --- M includes/Import/LiquidThreadsApi/Source.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/Import/LiquidThreadsApi/Source.php b/includes/Import/LiquidThreadsApi/Source.php index 53d2d5a..c4e70c5 100644 --- a/includes/Import/LiquidThreadsApi/Source.php +++ b/includes/Import/LiquidThreadsApi/Source.php @@ -316,12 +316,12 @@ $data = $this->apiCall( $conditions ); if ( ! isset( $data['query'] ) ) { - $this->logger->error( __METHOD__ . ': Failed API call against ' . $this->getKey() . ' with conditions : ' . json_encode( $conditions ) ); if ( $this->isNotFoundError( $data ) ) { $message = "Did not find pages: " . json_encode( $conditions ); $this->logger->debug( __METHOD__ . ": $message" ); throw new ApiNotFoundException( $message ); } else { + $this->logger->error( __METHOD__ . ': Failed API call against ' . $this->getKey() . ' with conditions : ' . json_encode( $conditions ) ); throw new ImportException( "Null response from API module: " . json_encode( $data ) ); } } elseif ( !$expectContinue && isset( $data['continue'] ) ) { -- To view, visit https://gerrit.wikimedia.org/r/313639 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I803458b2383a0ac7f091a0a8d3417ff444a3be4c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Catrope <r...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits