Jhernandez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313975
Change subject: Add npm script to check built assets on npm test
......................................................................
Add npm script to check built assets on npm test
That way if assets haven't been built and commited, the CI npm test will
fail.
It also exercises the build step in CI, so that things like missing
dependencies or broken builds can't be commited.
Change-Id: I4f5a56d3dc0716027f1a717d9922f0a1ec621d20
---
M package.json
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cards
refs/changes/75/313975/1
diff --git a/package.json b/package.json
index 4d49787..ce6a5c2 100644
--- a/package.json
+++ b/package.json
@@ -2,11 +2,12 @@
"name": "cards",
"version": "0.2.0",
"scripts": {
- "test": "grunt test && npm run test:js",
+ "test": "grunt test && npm run test:js && npm run check-built",
"test:js": "ava tests/js/",
"doc": "grunt doc",
"start": "webpack -w",
- "build": "NODE_ENV=production webpack -p"
+ "build": "NODE_ENV=production webpack -p",
+ "check-built": "echo 'CHECK BUILD SOURCES ARE COMMITED' && rm -rf
test-build && mv build test-build && npm run build && diff -r test-build build"
},
"devDependencies": {
"ava": "^0.16.0",
--
To view, visit https://gerrit.wikimedia.org/r/313975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f5a56d3dc0716027f1a717d9922f0a1ec621d20
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cards
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
