Divec has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313997
Change subject: Check for null keyDownSelectionState in handlers
......................................................................
Check for null keyDownSelectionState in handlers
Bug: T147304
Change-Id: I0b910feb6a09159915d987bbaa9bd45c1877d1b2
---
M src/ce/ve.ce.Surface.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/97/313997/1
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 6e1167b..bb27c09 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -83,7 +83,7 @@
// Snapshot updated at keyDown. See storeKeyDownState.
this.keyDownState = {
event: null,
- selection: null
+ selectionState: null
};
this.cursorDirectionality = null;
@@ -576,6 +576,7 @@
// Remove ranges so the user can't accidentally type into the
document
this.nativeSelection.removeAllRanges();
this.updateDeactivatedSelection();
+ this.clearKeyDownState();
}
};
@@ -1272,6 +1273,7 @@
function getDirection() {
return (
isArrow &&
+ keyDownSelectionState &&
ve.compareDocumentOrder(
surface.nativeSelection.focusNode,
surface.nativeSelection.focusOffset,
@@ -1360,6 +1362,7 @@
!e.ctrlKey &&
!e.altKey &&
!e.metaKey &&
+ keyDownSelectionState &&
keyDownSelectionState.isCollapsed &&
this.nativeSelection.isCollapsed &&
( direction = getDirection() ) !== null
--
To view, visit https://gerrit.wikimedia.org/r/313997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b910feb6a09159915d987bbaa9bd45c1877d1b2
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <da...@troi.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
