jenkins-bot has submitted this change and it was merged.
Change subject: Explicitly set "mobile edit" tag.
......................................................................
Explicitly set "mobile edit" tag.
Since the Android app no longer issues API requests through the mobile
domain, and instead communicates through the desktop domain, its edits
are not getting marked as "mobile edit", which throws off queries made
by analysts who want to track mobile edits.
This patch explicitly adds the "mobile edit" tag, in addition to the
existing "mobile app edit" tag, to edits that come from the app. This does
not seem to conflict with the MobileFrontend extension conditionally
adding the same tag.
Bug: T141667
Change-Id: I2e07c0264d7f7129dd476310d0e3199793ee8214
---
M MobileApp.hooks.php
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Mholloway: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MobileApp.hooks.php b/MobileApp.hooks.php
index e7c0ee8..9e120bf 100644
--- a/MobileApp.hooks.php
+++ b/MobileApp.hooks.php
@@ -10,6 +10,7 @@
* @return bool
*/
public static function onListDefinedTags( array &$tags ) {
+ $tags[] = 'mobile edit';
$tags[] = 'mobile app edit';
return true;
}
@@ -34,7 +35,12 @@
( $isWikipediaApp && is_null( $logType ) )
|| ( $isCommonsApp && ( is_null( $logType ) || $logType
== 'upload' ) )
) {
- $rc->addTags( 'mobile app edit' );
+ // Although MobileFrontend applies the "mobile edit"
tag to any edit
+ // that is made through the mobile domain, the Android
app actually
+ // makes its API requests through the desktop domain,
meaning that we
+ // must apply the "mobile edit" tag explicitly
ourselves, in addition
+ // to the "mobile app edit" tag.
+ $rc->addTags( [ 'mobile edit', 'mobile app edit' ] );
}
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/313618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e07c0264d7f7129dd476310d0e3199793ee8214
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileApp
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Fjalapeno <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
