Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314025
Change subject: Remove useless empty() methods
......................................................................
Remove useless empty() methods
2 of them are exactly the same as their parent, so redundant.
The other one has recently been added to moveTo and is now
no longer needed here.
Change-Id: I13bf05f0ff8fa508b1498c682b6731f71f3d05b2
---
M resources/controller/uw.controller.Details.js
M resources/controller/uw.controller.Upload.js
M resources/ui/steps/uw.ui.Details.js
3 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/25/314025/1
diff --git a/resources/controller/uw.controller.Details.js
b/resources/controller/uw.controller.Details.js
index 6ec57eb..f7e9e2e 100644
--- a/resources/controller/uw.controller.Details.js
+++ b/resources/controller/uw.controller.Details.js
@@ -91,10 +91,6 @@
}
};
- uw.controller.Details.prototype.empty = function () {
- this.ui.empty();
- };
-
/**
* Start details submit.
* TODO move the rest of the logic here from mw.UploadWizard
diff --git a/resources/controller/uw.controller.Upload.js
b/resources/controller/uw.controller.Upload.js
index 06fd57d..0e3416a 100644
--- a/resources/controller/uw.controller.Upload.js
+++ b/resources/controller/uw.controller.Upload.js
@@ -79,10 +79,6 @@
this.ui.showTooManyFilesWarning( filesUploaded );
};
- uw.controller.Upload.prototype.empty = function () {
- this.ui.empty();
- };
-
uw.controller.Upload.prototype.moveTo = function () {
this.updateFileCounts( [] );
uw.controller.Step.prototype.moveTo.call( this );
diff --git a/resources/ui/steps/uw.ui.Details.js
b/resources/ui/steps/uw.ui.Details.js
index eac5d28..e964c57 100644
--- a/resources/ui/steps/uw.ui.Details.js
+++ b/resources/ui/steps/uw.ui.Details.js
@@ -129,16 +129,6 @@
};
/**
- * Empty out all upload information.
- */
- uw.ui.Details.prototype.empty = function () {
- // reset buttons on the details page
- this.$div.find( '.mwe-upwiz-file-next-some-failed' ).hide();
- this.$div.find( '.mwe-upwiz-file-next-all-failed' ).hide();
- this.$div.find( '.mwe-upwiz-file-next-all-ok' ).show();
- };
-
- /**
* Hide buttons for moving to the next step.
*/
uw.ui.Details.prototype.hideEndButtons = function () {
--
To view, visit https://gerrit.wikimedia.org/r/314025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13bf05f0ff8fa508b1498c682b6731f71f3d05b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
