jenkins-bot has submitted this change and it was merged.
Change subject: Fix tap-to-hide image description in Gallery.
......................................................................
Fix tap-to-hide image description in Gallery.
Somewhere along the way, our functionality of tapping to hide/show the
image description in the Gallery has disappeared, probably because of
updates to the sample ZoomableDraweeView.
This reinstates that functionality in the correct way.
Change-Id: Ia9b21b55ba20a240f54881bf9e4526a3ff7cae4b
---
M app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Niedzielski: Looks good to me, approved
diff --git
a/app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
b/app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
index a8efda4..9b45772 100644
--- a/app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
+++ b/app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java
@@ -10,10 +10,12 @@
import android.support.annotation.Nullable;
import android.support.v4.app.Fragment;
import android.text.TextUtils;
+import android.view.GestureDetector;
import android.view.LayoutInflater;
import android.view.Menu;
import android.view.MenuInflater;
import android.view.MenuItem;
+import android.view.MotionEvent;
import android.view.View;
import android.view.ViewGroup;
import android.widget.MediaController;
@@ -59,7 +61,7 @@
private View videoPlayButton;
private MediaController mediaController;
- @NonNull private WikipediaApp app = WikipediaApp.getInstance();;
+ @NonNull private WikipediaApp app = WikipediaApp.getInstance();
@Nullable private GalleryActivity parentActivity;
@Nullable private PageTitle pageTitle;
@SuppressWarnings("NullableProblems") @NonNull private PageTitle
imageTitle;
@@ -99,10 +101,11 @@
videoThumbnail = (SimpleDraweeView)
rootView.findViewById(R.id.gallery_video_thumbnail);
videoPlayButton =
rootView.findViewById(R.id.gallery_video_play_button);
imageView = (ZoomableDraweeView)
rootView.findViewById(R.id.gallery_image);
- imageView.setOnClickListener(new View.OnClickListener() {
+ imageView.setTapListener(new GestureDetector.SimpleOnGestureListener()
{
@Override
- public void onClick(View v) {
+ public boolean onSingleTapConfirmed(MotionEvent e) {
parentActivity.toggleControls();
+ return true;
}
});
GenericDraweeHierarchy hierarchy = new
GenericDraweeHierarchyBuilder(getResources())
--
To view, visit https://gerrit.wikimedia.org/r/314037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9b21b55ba20a240f54881bf9e4526a3ff7cae4b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
