Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314173
Change subject: Add version to LoadMonitor::getCacheKey()
......................................................................
Add version to LoadMonitor::getCacheKey()
This avoids undefined index and "servers down" errors when
using Het Deploy.
Change-Id: Ic2d0d147df2e1c015ec4a6675294203b2adf5ed9
---
M includes/libs/rdbms/loadmonitor/LoadMonitor.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/73/314173/1
diff --git a/includes/libs/rdbms/loadmonitor/LoadMonitor.php
b/includes/libs/rdbms/loadmonitor/LoadMonitor.php
index 59075e4..60400e3 100644
--- a/includes/libs/rdbms/loadmonitor/LoadMonitor.php
+++ b/includes/libs/rdbms/loadmonitor/LoadMonitor.php
@@ -40,6 +40,8 @@
/** @var float Moving average ratio (e.g. 0.1 for 10% weight to new
weight) */
private $movingAveRatio;
+ const VERSION = 1;
+
public function __construct(
ILoadBalancer $lb, BagOStuff $srvCache, BagOStuff $cache, array
$options = []
) {
@@ -199,6 +201,7 @@
// Lag is per-server, not per-DB, so key on the master DB name
return $this->srvCache->makeGlobalKey(
'lag-times',
+ self::VERSION,
$this->parent->getServerName(
$this->parent->getWriterIndex() )
);
}
--
To view, visit https://gerrit.wikimedia.org/r/314173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2d0d147df2e1c015ec4a6675294203b2adf5ed9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
