jenkins-bot has submitted this change and it was merged.
Change subject: Only load when revisions are from the same title
......................................................................
Only load when revisions are from the same title
Bug: T147059
Change-Id: If5e3c89a6691dffbdbdeb1fcf81c3477587094bc
---
M RevisionSlider.hooks.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
WMDE-Fisch: Looks good to me, approved
jenkins-bot: Verified
diff --git a/RevisionSlider.hooks.php b/RevisionSlider.hooks.php
index ccc6619..96fbd00 100644
--- a/RevisionSlider.hooks.php
+++ b/RevisionSlider.hooks.php
@@ -27,10 +27,9 @@
}
/**
- * Do not show the RevisionSlider on special pages that use a
Diff view for example
- * Special:ComparePages
+ * Do not show the RevisionSlider when revisions from two
different pages are being compared
*/
- if ( $diff->getTitle()->inNamespace( NS_SPECIAL ) ) {
+ if ( !$oldRev->getTitle()->equals( $newRev->getTitle() ) ) {
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/314033
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5e3c89a6691dffbdbdeb1fcf81c3477587094bc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
