Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314429
Change subject: Revert "Fix empty property references"
......................................................................
Revert "Fix empty property references"
This reverts commit 1383299c828c479f537c6dfc060dce79c639e8c5.
First step of reverting a commit that needs more fixes.
Change-Id: Id801ff4ff2298121cc210ad8b59ec914b15f549b
---
M handlers/TextHandler/TextHandler.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/29/314429/1
diff --git a/handlers/TextHandler/TextHandler.php
b/handlers/TextHandler/TextHandler.php
index 3eb284e..4442dbd 100644
--- a/handlers/TextHandler/TextHandler.php
+++ b/handlers/TextHandler/TextHandler.php
@@ -289,8 +289,8 @@
}
function getForeignNamespaceName() {
- if ( $this->remoteNs !== null ) {
- return $this->remoteNsName;
+ if ( $this->$remoteNs !== null ) {
+ return $this->$remoteNsName;
}
/* Else, we use the canonical namespace, since we can't look up
the actual one */
return strtr( MWNamespace::getCanonicalName( NS_TIMEDTEXT ), '
', '_' );
--
To view, visit https://gerrit.wikimedia.org/r/314429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id801ff4ff2298121cc210ad8b59ec914b15f549b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
