Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314528
Change subject: Regression fix: don't load TMH JS modules when not needed
......................................................................
Regression fix: don't load TMH JS modules when not needed
When adding the videojs experimental mode we accidentally lost
a conditional check in the page output hook, causing TMH modules
to be loaded on every page.
Restored the conditional check, which should avoid loading
unneeded modules on pages without audio/video on them.
Change-Id: Ie2b4aaada2c8f274a3273207ff4590fdccc54e53
---
M TimedMediaHandler.hooks.php
1 file changed, 12 insertions(+), 10 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/28/314528/1
diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index 431510c..7ebd6b4 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -674,17 +674,19 @@
}
}
- if ( self::activePlayerMode() === 'mwembed' ) {
- $out->addModuleStyles( 'ext.tmh.thumbnail.styles' );
- $out->addModules( [
- 'mw.MediaWikiPlayer.loader',
- 'mw.PopUpMediaTransform',
- ] );
- }
+ if ( $addModules ) {
+ if ( self::activePlayerMode() === 'mwembed' ) {
+ $out->addModuleStyles(
'ext.tmh.thumbnail.styles' );
+ $out->addModules( [
+ 'mw.MediaWikiPlayer.loader',
+ 'mw.PopUpMediaTransform',
+ ] );
+ }
- if ( self::activePlayerMode() === 'videojs' ) {
- $out->addModuleStyles( 'ext.tmh.player.styles' );
- $out->addModules( 'ext.tmh.player' );
+ if ( self::activePlayerMode() === 'videojs' ) {
+ $out->addModuleStyles( 'ext.tmh.player.styles'
);
+ $out->addModules( 'ext.tmh.player' );
+ }
}
return true;
--
To view, visit https://gerrit.wikimedia.org/r/314528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2b4aaada2c8f274a3273207ff4590fdccc54e53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
