Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314555
Change subject: Introduce the "entitiesWithoutTermEntityTypes" setting
......................................................................
Introduce the "entitiesWithoutTermEntityTypes" setting
Deploy: Override this in production so that it only
contains "item" (for performance reasons).
Bug: T140891
Change-Id: I45734dc9797846a2522f08f4e229a5ccc5a608a4
---
M docs/options.wiki
M repo/config/Wikibase.default.php
M repo/includes/Specials/SpecialEntitiesWithoutPageFactory.php
3 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/55/314555/1
diff --git a/docs/options.wiki b/docs/options.wiki
index 562e080..0e9e20d 100644
--- a/docs/options.wiki
+++ b/docs/options.wiki
@@ -50,6 +50,7 @@
;allowEntityImport: Allow importing entities via Special:Import and
importDump.php. Per default, imports are forbidden, since entities defined in
another wiki would have or use IDs that conflict with entities defined locally.
;pagePropertiesRdf: Array that maps between page properties and Wikibase
predicates for RDF dumps. Maps from database property name to an array that
contains a key <code>'name'</code> (RDF property name, which will be prefixed
by <code>wikibase:</code>) and an optional key <code>'type'</code>.
;unitStorage: Definition for unit conversion storage. Should be in in the
format <code>ObjectFactory</code> understands, example: <code>array( 'class' =>
'Wikibase\\Lib\\JsonUnitStorage', 'args' => array( 'myUnits.json' ) )</code>.
+;entitiesWithoutTermEntityTypes: Array of entity types that are supported on
Special:EntitiesWithoutLabel and on Special:EntitiesWithoutDescription. Can
contain either "item" or "property" (or both).
== Client Settings ==
diff --git a/repo/config/Wikibase.default.php b/repo/config/Wikibase.default.php
index 3f59c3f..9539325 100644
--- a/repo/config/Wikibase.default.php
+++ b/repo/config/Wikibase.default.php
@@ -193,5 +193,10 @@
'pagePropertiesRdf' => [
'wb-sitelinks' => [ 'name' => 'sitelinks', 'type' => 'integer'
],
'wb-claims' => [ 'name' => 'statements', 'type' => 'integer' ],
+ ],
+
+ 'entitiesWithoutTermEntityTypes' => [
+ 'item',
+ 'property'
]
];
diff --git a/repo/includes/Specials/SpecialEntitiesWithoutPageFactory.php
b/repo/includes/Specials/SpecialEntitiesWithoutPageFactory.php
index d98b5db..ff49a98 100644
--- a/repo/includes/Specials/SpecialEntitiesWithoutPageFactory.php
+++ b/repo/includes/Specials/SpecialEntitiesWithoutPageFactory.php
@@ -20,10 +20,11 @@
private static function newFromGlobalState() {
$wikibaseRepo = WikibaseRepo::getDefaultInstance();
+ $entityTypes = $wikibaseRepo->getSettings()->getSetting(
'entitiesWithoutTermEntityTypes' );
return new self(
$wikibaseRepo->getStore()->newEntitiesWithoutTermFinder(),
- $wikibaseRepo->getEnabledEntityTypes(),
+ $entityTypes,
$wikibaseRepo->getTermsLanguages(),
new LanguageNameLookup()
);
--
To view, visit https://gerrit.wikimedia.org/r/314555
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45734dc9797846a2522f08f4e229a5ccc5a608a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
