jenkins-bot has submitted this change and it was merged. Change subject: JSON-encode stuff before giving to Redis ......................................................................
JSON-encode stuff before giving to Redis Otherwise, Python/Redis will do its own thing, which involves single-quoted, "u"nicode-prefixed and other non-JSON serialization. Bug: T147532 Change-Id: I68d8eaf1e95213ba9d3a2c2b1c8e6aa01f209dd8 --- M queue/redis_wrap.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Ejegg: Looks good to me, approved jenkins-bot: Verified diff --git a/queue/redis_wrap.py b/queue/redis_wrap.py index 570788b..4c57279 100644 --- a/queue/redis_wrap.py +++ b/queue/redis_wrap.py @@ -14,11 +14,13 @@ def send(self, queue, msg): + encoded = json.dumps(msg) + if config.no_effect: - log.info("not queueing message. " + json.dumps(msg)) + log.info("not queueing message. " + encoded) return if config.redis.queues[queue]: - self.conn.rpush(config.redis.queues[queue], msg) + self.conn.rpush(config.redis.queues[queue], encoded) else: - self.conn.rpush(queue, msg) + self.conn.rpush(queue, encoded) -- To view, visit https://gerrit.wikimedia.org/r/314468 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68d8eaf1e95213ba9d3a2c2b1c8e6aa01f209dd8 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Awight <awi...@wikimedia.org> Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits