Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314672
Change subject: Remove unused imports
......................................................................
Remove unused imports
I found these with a regular expression and checked each use clause
individually. This makes sure I'm not removing class names that are
mentioned in comments. Certain tools tend to ignore PHPDoc comment
blocks while optimizing imports.
Change-Id: Ib096b2293a29aa8e4a992be56cfc35f531154bee
---
M includes/Block/Topic.php
M includes/Block/TopicSummary.php
M includes/Data/Listener/NotificationListener.php
M includes/Data/Listener/WatchTopicListener.php
M includes/Dump/Exporter.php
M includes/Formatter/AbstractFormatter.php
M includes/Formatter/HistoryQuery.php
M includes/Formatter/TocTopicListFormatter.php
M includes/Import/Postprocessor/LqtRedirector.php
M includes/Import/Postprocessor/ProcessorGroup.php
M includes/Import/Postprocessor/SpecialLogTopic.php
M includes/LinksTableUpdater.php
M includes/Notifications/FlowPresentationModel.php
M includes/Notifications/PostReplyPresentationModel.php
M maintenance/FlowAddMissingModerationLogs.php
M maintenance/dumpBackup.php
M tests/phpunit/Notifications/NotificationControllerTest.php
M tests/phpunit/Notifications/NotifiedUsersTest.php
M tests/phpunit/api/ApiWatchTopicTest.php
19 files changed, 0 insertions(+), 23 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/72/314672/1
diff --git a/includes/Block/Topic.php b/includes/Block/Topic.php
index aa2120f..acb853c 100644
--- a/includes/Block/Topic.php
+++ b/includes/Block/Topic.php
@@ -3,7 +3,6 @@
namespace Flow\Block;
use Flow\Container;
-use Flow\Conversion\Utils;
use Flow\Data\ManagerGroup;
use Flow\Data\Pager\HistoryPager;
use Flow\Exception\DataModelException;
diff --git a/includes/Block/TopicSummary.php b/includes/Block/TopicSummary.php
index ef159cb..c052e12 100644
--- a/includes/Block/TopicSummary.php
+++ b/includes/Block/TopicSummary.php
@@ -3,7 +3,6 @@
namespace Flow\Block;
use Flow\Container;
-use Flow\Conversion\Utils;
use Flow\Exception\FailCommitException;
use Flow\Exception\FlowException;
use Flow\Exception\InvalidActionException;
diff --git a/includes/Data/Listener/NotificationListener.php
b/includes/Data/Listener/NotificationListener.php
index fcc3c3e..7c12cc4 100644
--- a/includes/Data/Listener/NotificationListener.php
+++ b/includes/Data/Listener/NotificationListener.php
@@ -3,11 +3,8 @@
namespace Flow\Data\Listener;
use Flow\Exception\InvalidDataException;
-use Flow\Exception\InvalidInputException;
use Flow\Model\AbstractRevision;
-use Flow\Model\Header;
use Flow\Model\PostRevision;
-use Flow\Model\PostSummary;
use Flow\Model\Workflow;
use Flow\NotificationController;
diff --git a/includes/Data/Listener/WatchTopicListener.php
b/includes/Data/Listener/WatchTopicListener.php
index f6cc27a..c74dcbd 100644
--- a/includes/Data/Listener/WatchTopicListener.php
+++ b/includes/Data/Listener/WatchTopicListener.php
@@ -10,7 +10,6 @@
use Flow\WatchedTopicItems;
use Title;
use User;
-use WatchedItem;
/**
* Auto-watch topics when the user performs one of the actions specified
diff --git a/includes/Dump/Exporter.php b/includes/Dump/Exporter.php
index 1e170e7..75fe0ee 100644
--- a/includes/Dump/Exporter.php
+++ b/includes/Dump/Exporter.php
@@ -12,7 +12,6 @@
use Flow\Model\Header;
use Flow\Model\PostRevision;
use Flow\Model\PostSummary;
-use Flow\Model\UUID;
use Flow\Model\Workflow;
use Flow\RevisionActionPermissions;
use Flow\Search\Iterators\AbstractIterator;
diff --git a/includes/Formatter/AbstractFormatter.php
b/includes/Formatter/AbstractFormatter.php
index 88f5abf..f576e22 100644
--- a/includes/Formatter/AbstractFormatter.php
+++ b/includes/Formatter/AbstractFormatter.php
@@ -3,7 +3,6 @@
namespace Flow\Formatter;
use Flow\Container;
-use Flow\Conversion\Utils;
use Flow\FlowActions;
use Flow\Model\Anchor;
use Flow\Model\PostRevision;
diff --git a/includes/Formatter/HistoryQuery.php
b/includes/Formatter/HistoryQuery.php
index b845994..b0b5730 100644
--- a/includes/Formatter/HistoryQuery.php
+++ b/includes/Formatter/HistoryQuery.php
@@ -2,7 +2,6 @@
namespace Flow\Formatter;
-use Flow\Exception\InvalidDataException;
use Flow\FlowActions;
use Flow\Data\ManagerGroup;
use Flow\Model\AbstractRevision;
diff --git a/includes/Formatter/TocTopicListFormatter.php
b/includes/Formatter/TocTopicListFormatter.php
index cded65c..6834013 100644
--- a/includes/Formatter/TocTopicListFormatter.php
+++ b/includes/Formatter/TocTopicListFormatter.php
@@ -2,7 +2,6 @@
namespace Flow\Formatter;
-use Flow\Conversion\Utils;
use Flow\Data\Pager\PagerPage;
use Flow\Model\Workflow;
use Flow\Templating;
diff --git a/includes/Import/Postprocessor/LqtRedirector.php
b/includes/Import/Postprocessor/LqtRedirector.php
index a8f91fb..a61d297 100644
--- a/includes/Import/Postprocessor/LqtRedirector.php
+++ b/includes/Import/Postprocessor/LqtRedirector.php
@@ -15,7 +15,6 @@
use MediaWiki\MediaWikiServices;
use Title;
use User;
-use WatchedItem;
use WikiPage;
use WikitextContent;
diff --git a/includes/Import/Postprocessor/ProcessorGroup.php
b/includes/Import/Postprocessor/ProcessorGroup.php
index d6931ba..7c63141 100644
--- a/includes/Import/Postprocessor/ProcessorGroup.php
+++ b/includes/Import/Postprocessor/ProcessorGroup.php
@@ -3,7 +3,6 @@
namespace Flow\Import\Postprocessor;
use Flow\Model\PostRevision;
-use Flow\Model\UUID;
use Flow\Import\IImportHeader;
use Flow\Import\IImportPost;
use Flow\Import\IImportTopic;
diff --git a/includes/Import/Postprocessor/SpecialLogTopic.php
b/includes/Import/Postprocessor/SpecialLogTopic.php
index 8ad8798..7535fa4 100644
--- a/includes/Import/Postprocessor/SpecialLogTopic.php
+++ b/includes/Import/Postprocessor/SpecialLogTopic.php
@@ -8,7 +8,6 @@
use Flow\Import\PageImportState;
use Flow\Import\TopicImportState;
use Flow\Model\PostRevision;
-use Flow\Model\UUID;
use ManualLogEntry;
use User;
diff --git a/includes/LinksTableUpdater.php b/includes/LinksTableUpdater.php
index ed9e655..ad751db 100644
--- a/includes/LinksTableUpdater.php
+++ b/includes/LinksTableUpdater.php
@@ -2,7 +2,6 @@
namespace Flow;
-use DataUpdate;
use DeferredUpdates;
use Flow\Data\ManagerGroup;
use Flow\Model\Reference;
diff --git a/includes/Notifications/FlowPresentationModel.php
b/includes/Notifications/FlowPresentationModel.php
index 6154bed..8fd09e1 100644
--- a/includes/Notifications/FlowPresentationModel.php
+++ b/includes/Notifications/FlowPresentationModel.php
@@ -2,8 +2,6 @@
namespace Flow;
-use EchoDiscussionParser;
-use EchoEvent;
use EchoEventPresentationModel;
use Flow\Model\UUID;
use Title;
diff --git a/includes/Notifications/PostReplyPresentationModel.php
b/includes/Notifications/PostReplyPresentationModel.php
index 378a1f4..4a2cab0 100644
--- a/includes/Notifications/PostReplyPresentationModel.php
+++ b/includes/Notifications/PostReplyPresentationModel.php
@@ -2,8 +2,6 @@
namespace Flow;
-use Flow\Model\UUID;
-
class PostReplyPresentationModel extends FlowPresentationModel {
public function getIconType() {
diff --git a/maintenance/FlowAddMissingModerationLogs.php
b/maintenance/FlowAddMissingModerationLogs.php
index 750e9b0..bd97ba3 100644
--- a/maintenance/FlowAddMissingModerationLogs.php
+++ b/maintenance/FlowAddMissingModerationLogs.php
@@ -1,7 +1,6 @@
<?php
use Flow\Container;
-use Flow\Data\Listener\ModerationLoggingListener;
use Flow\Model\AbstractRevision;
use Flow\Model\UUID;
diff --git a/maintenance/dumpBackup.php b/maintenance/dumpBackup.php
index 41389c8..d7e4c18 100644
--- a/maintenance/dumpBackup.php
+++ b/maintenance/dumpBackup.php
@@ -2,7 +2,6 @@
use Flow\Container;
use Flow\Dump\Exporter;
-use Flow\Model\UUID;
$maintPath = ( getenv( 'MW_INSTALL_PATH' ) !== false
? getenv( 'MW_INSTALL_PATH' ) . '/maintenance'
diff --git a/tests/phpunit/Notifications/NotificationControllerTest.php
b/tests/phpunit/Notifications/NotificationControllerTest.php
index a15a976..0189aac 100644
--- a/tests/phpunit/Notifications/NotificationControllerTest.php
+++ b/tests/phpunit/Notifications/NotificationControllerTest.php
@@ -3,7 +3,6 @@
namespace Flow\Tests;
use Flow\Container;
-use Flow\NotificationController;
use Flow\Model\UUID;
use TestingAccessWrapper;
diff --git a/tests/phpunit/Notifications/NotifiedUsersTest.php
b/tests/phpunit/Notifications/NotifiedUsersTest.php
index 0b3b95c..de69c09 100644
--- a/tests/phpunit/Notifications/NotifiedUsersTest.php
+++ b/tests/phpunit/Notifications/NotifiedUsersTest.php
@@ -10,7 +10,6 @@
use Flow\NotificationController;
use EchoNotificationController;
use User;
-use WatchedItem;
/**
* @group Flow
diff --git a/tests/phpunit/api/ApiWatchTopicTest.php
b/tests/phpunit/api/ApiWatchTopicTest.php
index cb1da6c..948a277 100644
--- a/tests/phpunit/api/ApiWatchTopicTest.php
+++ b/tests/phpunit/api/ApiWatchTopicTest.php
@@ -4,7 +4,6 @@
use Title;
use User;
-use WatchedItem;
/**
* @group Flow
--
To view, visit https://gerrit.wikimedia.org/r/314672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib096b2293a29aa8e4a992be56cfc35f531154bee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
