Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314674
Change subject: Remove jquery.effects.core dependency from tagadata
......................................................................
Remove jquery.effects.core dependency from tagadata
This whole highlighting feature is unused, as you can see in the CSS.
Change-Id: Iab0fb5b238eac652a4d8cf29ae547b3e0aed2c9d
---
M view/resources/jquery/ui/jquery.ui.tagadata.css
M view/resources/jquery/ui/jquery.ui.tagadata.js
M view/resources/jquery/ui/resources.php
3 files changed, 1 insertion(+), 32 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/74/314674/1
diff --git a/view/resources/jquery/ui/jquery.ui.tagadata.css
b/view/resources/jquery/ui/jquery.ui.tagadata.css
index 0d67a2a..13410cc 100644
--- a/view/resources/jquery/ui/jquery.ui.tagadata.css
+++ b/view/resources/jquery/ui/jquery.ui.tagadata.css
@@ -55,8 +55,6 @@
display: none;
}
-ul.tagadata li.tagadata-choice-existing {}
-
ul.tagadata li.tagadata-choice-empty .tagadata-label-text, /* don't underline
when only placeholder is displayed */
ul.tagadata li.tagadata-choice:last-of-type.tagadata-choice-equal
.tagadata-label-text /* don't underline when conflict */ {
text-decoration:none;
diff --git a/view/resources/jquery/ui/jquery.ui.tagadata.js
b/view/resources/jquery/ui/jquery.ui.tagadata.js
index 39a8d4d..77ccff7 100644
--- a/view/resources/jquery/ui/jquery.ui.tagadata.js
+++ b/view/resources/jquery/ui/jquery.ui.tagadata.js
@@ -153,7 +153,7 @@
} else {
$tag
.removeClass( 'tagadata-choice
ui-widget-content '
- + 'ui-state-default ui-corner-all
ui-state-highlight remove' )
+ + 'ui-state-default ui-corner-all
remove' )
.empty()
.off( '.' + this.widgetName )
.text( text );
@@ -253,29 +253,6 @@
},
/**
- * Highlights a tag for a short time.
- *
- * @param {jQuery} $tag
- */
- highlightTag: function( $tag ) {
- $tag.switchClass(
- '',
- 'tagadata-choice-existing ui-state-highlight',
- 150,
- 'linear',
- function() {
- // also remove 'remove' class to avoid confusion
- $tag.switchClass(
- 'tagadata-choice-existing
ui-state-highlight remove',
- '',
- 750,
- 'linear'
- );
- }
- );
- },
-
- /**
* Adds a new tag to the list of tags. If the tag exists in the list
already, the existing tag
* will be returned.
*
@@ -290,10 +267,6 @@
var $tag = this.getTag( value );
if ( $tag ) {
- if ( value !== '' ) {
- // highlight the already existing tag, except
if it is the new tag input
- this.highlightTag( $tag );
- }
return $tag;
}
@@ -403,7 +376,6 @@
// Remove tag if hit ENTER on an empty
tag, except for the helper tag.
if ( $targetTag.get( 0 ) !== $tag.get(
0 ) ) {
self.removeTag( $tag );
- self.highlightTag( $targetTag );
}
}
$targetTag.find( 'input' ).focus();
diff --git a/view/resources/jquery/ui/resources.php
b/view/resources/jquery/ui/resources.php
index ee7fc3f..0d214dc 100644
--- a/view/resources/jquery/ui/resources.php
+++ b/view/resources/jquery/ui/resources.php
@@ -37,7 +37,6 @@
),
'dependencies' => array(
'jquery.event.special.eachchange',
- 'jquery.effects.core',
'jquery.inputautoexpand',
'jquery.ui.widget',
),
--
To view, visit https://gerrit.wikimedia.org/r/314674
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab0fb5b238eac652a4d8cf29ae547b3e0aed2c9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
