Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/314676

Change subject: test: raise_error() should have an explicit message
......................................................................

test: raise_error() should have an explicit message

When running the test suite with rspec 3.5, a new warning is raised
stating the expectation 'raise_error' should have an explicit message to
catch.

Change-Id: I4481e5998182af490ee5b443c621f5db41c74cae
---
M spec/environment_spec.rb
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/76/314676/1

diff --git a/spec/environment_spec.rb b/spec/environment_spec.rb
index f2d2de1..ce6b254 100644
--- a/spec/environment_spec.rb
+++ b/spec/environment_spec.rb
@@ -649,7 +649,8 @@
 
         context 'when an exception is raised within the block' do
           it 'restores the original configuration and lets the exception be 
raised' do
-            expect { env.with_alternative(:mediawiki_url, :b) { raise 'error' 
} }.to raise_error
+            expect { env.with_alternative(:mediawiki_url, :b) { raise 'test 
error' } }.
+                         to raise_error('test error')
             expect(env[:mediawiki_url]).to eq('http://a.example/wiki')
           end
         end

-- 
To view, visit https://gerrit.wikimedia.org/r/314676
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4481e5998182af490ee5b443c621f5db41c74cae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to