Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314692
Change subject: Refactor expand browsertests
......................................................................
Refactor expand browsertests
- Applied the Given-When-Then rule to scenarios
Bug: T146276
Change-Id: I08aabda113d6ad9f1bbf06161484143549b13a7c
---
M tests/browser/features/expand.feature
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/92/314692/1
diff --git a/tests/browser/features/expand.feature
b/tests/browser/features/expand.feature
index c04185c..8110665 100644
--- a/tests/browser/features/expand.feature
+++ b/tests/browser/features/expand.feature
@@ -13,16 +13,13 @@
Scenario: RevisionSlider loads after expanding
Given I am on the diff page
- And I click on the expand button
+ When I click on the expand button
Then RevisionSlider wrapper should be visible
And The RevisionSlider has loaded
Scenario: RevisionSlider hides after collapsing
Given I am on the diff page
- And I click on the expand button
- Then RevisionSlider wrapper should be visible
+ When I click on the expand button
And The RevisionSlider has loaded
- And I have closed the help dialog at the start
- And The help dialog is hidden
- Given I click on the expand button
+ And I click on the expand button
Then RevisionSlider wrapper should be hidden
--
To view, visit https://gerrit.wikimedia.org/r/314692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08aabda113d6ad9f1bbf06161484143549b13a7c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
