Kelson has submitted this change and it was merged. Change subject: Avoid get the dirent too many time. ......................................................................
Avoid get the dirent too many time. Article::is* functions are "alias" to Article::getDirent().is* functions. As we already get the dirent just before, directly use the functions on the dirent, not the article. This way, we avoid calls to getDirent(). Change-Id: Ida3531c540b4848ee7028fee420eefa68aea3d40 --- M zimlib/include/zim/article.h 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Kelson: Verified; Looks good to me, approved diff --git a/zimlib/include/zim/article.h b/zimlib/include/zim/article.h index b950173..f2ece1e 100644 --- a/zimlib/include/zim/article.h +++ b/zimlib/include/zim/article.h @@ -79,19 +79,19 @@ Blob getData() const { Dirent dirent = getDirent(); - return isRedirect() - || isLinktarget() - || isDeleted() ? Blob() - : const_cast<File&>(file).getBlob(dirent.getClusterNumber(), dirent.getBlobNumber()); + return dirent.isRedirect() + || dirent.isLinktarget() + || dirent.isDeleted() ? Blob() + : const_cast<File&>(file).getBlob(dirent.getClusterNumber(), dirent.getBlobNumber()); } offset_type getOffset() const { Dirent dirent = getDirent(); - return isRedirect() - || isLinktarget() - || isDeleted() ? 0 - : const_cast<File&>(file).getOffset(dirent.getClusterNumber(), dirent.getBlobNumber()); + return dirent.isRedirect() + || dirent.isLinktarget() + || dirent.isDeleted() ? 0 + : const_cast<File&>(file).getOffset(dirent.getClusterNumber(), dirent.getBlobNumber()); } std::string getPage(bool layout = true, unsigned maxRecurse = 10); -- To view, visit https://gerrit.wikimedia.org/r/314717 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida3531c540b4848ee7028fee420eefa68aea3d40 Gerrit-PatchSet: 1 Gerrit-Project: openzim Gerrit-Branch: master Gerrit-Owner: Mgautierfr <mgaut...@kymeria.fr> Gerrit-Reviewer: Kelson <kel...@kiwix.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits